Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2100841: Print the "export KUBECONFIG=..." command on its own line for easier cut-and-paste #6018

Merged

Conversation

danwinship
Copy link
Contributor

instead of saying

INFO To access the cluster as the system:admin user when using 'oc', run 'export KUBECONFIG=/home/danw/Desktop/cluster/auth/kubeconfig' 

say

INFO To access the cluster as the system:admin user when using 'oc', run
    export KUBECONFIG=/home/danw/Desktop/cluster/auth/kubeconfig

so you can just triple-click the line to select it rather than having to carefully select between the quote marks

@openshift-ci openshift-ci bot requested review from a user and jcpowermac June 16, 2022 15:03
@ghost
Copy link

ghost commented Jun 16, 2022

/lgtm

@ghost
Copy link

ghost commented Jun 16, 2022

@danwinship we are in the feature freeze period. AFAIK for this PR will either need a Bugzilla assigned, or you will have to wait for the 4.12 development branch to be opened.

@openshift-ci openshift-ci bot assigned ghost Jun 16, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2022
@danwinship
Copy link
Contributor Author

do you want it for 4.11? I could create a bug I guess but it's not like this is super urgent...

@ghost
Copy link

ghost commented Jun 16, 2022

@danwinship I have no strong opinion on this, I just thought it worth mentioning. I think this will be fine for 4.12.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2022

@danwinship: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-proxy 68f22f8 link false /test e2e-aws-proxy
ci/prow/e2e-openstack 68f22f8 link false /test e2e-openstack
ci/prow/e2e-vsphere 68f22f8 link false /test e2e-vsphere
ci/prow/e2e-crc 68f22f8 link false /test e2e-crc
ci/prow/e2e-openstack-parallel 68f22f8 link false /test e2e-openstack-parallel
ci/prow/e2e-gcp 68f22f8 link false /test e2e-gcp
ci/prow/e2e-gcp-shared-vpc 68f22f8 link false /test e2e-gcp-shared-vpc
ci/prow/e2e-libvirt 68f22f8 link false /test e2e-libvirt
ci/prow/e2e-aws-single-node 68f22f8 link false /test e2e-aws-single-node
ci/prow/e2e-openstack-kuryr 68f22f8 link false /test e2e-openstack-kuryr
ci/prow/e2e-metal-ipi 68f22f8 link false /test e2e-metal-ipi
ci/prow/e2e-ibmcloud 68f22f8 link false /test e2e-ibmcloud
ci/prow/e2e-azurestack 68f22f8 link false /test e2e-azurestack
ci/prow/e2e-azure-shared-vpc 68f22f8 link false /test e2e-azure-shared-vpc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

Let's get this in 4.12
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janosdebugs, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
@ghost
Copy link

ghost commented Jun 24, 2022

@danwinship in this case, can you create a BZ and edit the title? :)

@danwinship danwinship changed the title Print the "export KUBECONFIG=..." command on its own line for easier cut-and-paste Bug 2100841: Print the "export KUBECONFIG=..." command on its own line for easier cut-and-paste Jun 24, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2022

@danwinship: This pull request references Bugzilla bug 2100841, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2100841: Print the "export KUBECONFIG=..." command on its own line for easier cut-and-paste

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2022

@danwinship: This pull request references Bugzilla bug 2100841, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gpei@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor

Or we can get it in 4.11 :)

@ghost
Copy link

ghost commented Jun 24, 2022

Oops, I actually misread your comment @patrickdillon :D

@openshift-ci openshift-ci bot merged commit 6daed68 into openshift:master Jun 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2022

@danwinship: All pull requests linked via external trackers have merged:

Bugzilla bug 2100841 has been moved to the MODIFIED state.

In response to this:

Bug 2100841: Print the "export KUBECONFIG=..." command on its own line for easier cut-and-paste

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants