-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2100841: Print the "export KUBECONFIG=..." command on its own line for easier cut-and-paste #6018
Bug 2100841: Print the "export KUBECONFIG=..." command on its own line for easier cut-and-paste #6018
Conversation
/lgtm |
@danwinship we are in the feature freeze period. AFAIK for this PR will either need a Bugzilla assigned, or you will have to wait for the 4.12 development branch to be opened. |
do you want it for 4.11? I could create a bug I guess but it's not like this is super urgent... |
@danwinship I have no strong opinion on this, I just thought it worth mentioning. I think this will be fine for 4.12. |
@danwinship: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Let's get this in 4.12 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: janosdebugs, patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@danwinship in this case, can you create a BZ and edit the title? :) |
@danwinship: This pull request references Bugzilla bug 2100841, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@danwinship: This pull request references Bugzilla bug 2100841, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gpei@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Or we can get it in 4.11 :) |
Oops, I actually misread your comment @patrickdillon :D |
@danwinship: All pull requests linked via external trackers have merged: Bugzilla bug 2100841 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
instead of saying
say
so you can just triple-click the line to select it rather than having to carefully select between the quote marks