-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verifying yq is installed properly in libvirt installer containers #6319
Verifying yq is installed properly in libvirt installer containers #6319
Conversation
56d2b0a
to
2e9fc87
Compare
2e9fc87
to
db7deb6
Compare
/assign @patrickdillon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks in line to how it's done in UPI: #6008. I'll wait on the e2e-libvirt
job before giving a lgtm.
/lgtm |
Is #6008 doing the same thing? |
/test e2e-libvirt |
2 similar comments
/test e2e-libvirt |
/test e2e-libvirt |
|
@patrickdillon can we get this merged? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/e2e-libvirt |
@sadasu: Overrode contexts on behalf of sadasu: ci/prow/e2e-libvirt In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@deepsm007: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Found recent failure in CI with incorrectly downloaded yq
https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-multiarch-master-nightly-4.12-ocp-e2e-sdn-remote-libvirt-ppc64le/1567624076510367744#1:build-log.txt%3A34-40
cc @r4f4