Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AGENT-288 Log rendezvous host IP when creating agent ISO #6393

Merged
merged 1 commit into from
Sep 23, 2022
Merged

AGENT-288 Log rendezvous host IP when creating agent ISO #6393

merged 1 commit into from
Sep 23, 2022

Conversation

rwsu
Copy link
Contributor

@rwsu rwsu commented Sep 22, 2022

The rendezvous host IP (node0 IP) can be specified in the agent-config.yaml or automatically chosen from the NMStateConfigs.

The IP address is logged at INFO level to help users know which host has been chosen as the rendezvous host.

Signed-off-by: Richard Su rwsu@redhat.com

@rwsu
AGENT-288 Log rendezvous host IP when creating agent ISO
a50c204 
The rendezvous host IP (node0 IP) can be specified in the
agent-config.yaml or automatically chosen from the NMStateConfigs.

The IP address is logged at INFO level to help users know which
host has been chosen as the rendezvous host.

Signed-off-by: Richard Su <rwsu@redhat.com>
@lranjbar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2022
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022
@pawanpinjarkar
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pawanpinjarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lranjbar
Copy link
Contributor

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2022

@rwsu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn a50c204 link false /test okd-e2e-aws-ovn
ci/prow/okd-e2e-gcp-ovn-upgrade a50c204 link false /test okd-e2e-gcp-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andfasano
Copy link
Contributor

/test-required

@openshift-merge-robot openshift-merge-robot merged commit a6a6b47 into openshift:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanpinjarkar pawanpinjarkar pawanpinjarkar approved these changes

@bfournie bfournie Awaiting requested review from bfournie

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@lranjbar lranjbar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rwsu @lranjbar @pawanpinjarkar @andfasano @openshift-merge-robot