Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-7400: Check for AWS STS installation before trying to get all IAM Roles #7141

Merged
merged 1 commit into from
May 1, 2023
Merged

[release-4.12] OCPBUGS-7400: Check for AWS STS installation before trying to get all IAM Roles #7141

merged 1 commit into from
May 1, 2023

Conversation

sadasu
Copy link
Contributor

@sadasu sadasu commented Apr 28, 2023

This is an manual cherry-pick of #6666

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2023

@sadasu: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] OCPBUGS-7400: Check for AWS STS installation before trying to get all IAM Roles

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 28, 2023
@openshift-ci-robot
Copy link
Contributor

@sadasu: This pull request references Jira Issue OCPBUGS-7400, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-1769 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-1769 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (yuwan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an manual cherry-pick of #6666

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2023 •
edited
Loading

@sadasu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade 102f510 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-disruptive 102f510 link false /test e2e-aws-ovn-disruptive
ci/prow/e2e-aws-ovn-imdsv2 102f510 link false /test e2e-aws-ovn-imdsv2
ci/prow/e2e-aws-ovn-single-node 102f510 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-proxy 102f510 link false /test e2e-aws-ovn-proxy
ci/prow/e2e-aws-ovn-shared-vpc 102f510 link false /test e2e-aws-ovn-shared-vpc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2023
@gpei
Copy link
Contributor

gpei commented Apr 29, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 29, 2023
@sadasu
Copy link
Contributor Author

sadasu commented May 1, 2023

/retest-required

barbacbd
barbacbd reviewed May 1, 2023
View reviewed changes
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2023
@openshift-merge-robot openshift-merge-robot merged commit 5ec086d into openshift:release-4.12 May 1, 2023
@openshift-ci-robot
Copy link
Contributor

@sadasu: Jira Issue OCPBUGS-7400: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-7400 has been moved to the MODIFIED state.

In response to this:

This is an manual cherry-pick of #6666

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-container-v4.12.0-202305011354.p0.g5ec086d.assembly.stream for distgit ose-installer.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-baremetal-installer-container-v4.12.0-202305011354.p0.g5ec086d.assembly.stream for distgit ose-baremetal-installer.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-artifacts-container-v4.12.0-202305011354.p0.g5ec086d.assembly.stream for distgit ose-installer-artifacts.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.12.0-0.nightly-2023-05-01-175018

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-container-v4.12.0-202305022015.p0.g5ec086d.assembly.stream for distgit ose-installer.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-baremetal-installer-container-v4.12.0-202305022015.p0.g5ec086d.assembly.stream for distgit ose-baremetal-installer.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-artifacts-container-v4.12.0-202305022015.p0.g5ec086d.assembly.stream for distgit ose-installer-artifacts.
All builds following this will include this PR.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbacbd barbacbd barbacbd left review comments

@mtulio mtulio Awaiting requested review from mtulio

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@barbacbd barbacbd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sadasu @openshift-ci-robot @patrickdillon @gpei @openshift-bot @openshift-merge-robot @barbacbd