OCPBUGS-19037: Handle agent tui failure gracefully #7490
Conversation
By setting agent-interactive-service RequiredBy sshd and systemd-logind, we prevent the user from ever logging in to the host if the agent-tui process fails. This makes it impossible to debug the failure. We want to start the agent-tui whenever tty1 exists (which in practice seems to be always, even if there is only a serial console). To ensure that we don't block subsequent login to the console after a failure, use WantedBy instead of RequiredBy. The other install dependencies are not needed.
If agent-tui fails to start, we still want to switch back to the regular VT and re-enable systemd status. Since ExecStartPost commands only run if ExecStart succeeds, use ExecStopPost instead. This means disabling RemainAfterExit (which is not needed anyway) so that the service also stops on success.
openshift-ci-robot
added
jira/severity-important
|
@zaneb: This pull request references Jira Issue OCPBUGS-19037, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
/cherry-pick release-4.14 |
|
@zaneb: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
/cc @rwsu |
|
/test e2e-agent-sno-ipv4-pxe |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@zaneb: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
openshift-merge-robot
merged commit 4e4eec6
into
openshift:master
|
@zaneb: Jira Issue OCPBUGS-19037: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-19037 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@zaneb: new pull request created: #7497 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If agent-tui fails to run, just carry on and don't block the console and ssh login.