Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-19319: Handle agent tui failure gracefully #7497

Merged
merged 2 commits into from Sep 26, 2023
Merged

[release-4.14] OCPBUGS-19319: Handle agent tui failure gracefully #7497

merged 2 commits into from Sep 26, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #7490

/assign zaneb

@zaneb
Don't block login on agent-tui
a1248ba 
By setting agent-interactive-service RequiredBy sshd and systemd-logind,
we prevent the user from ever logging in to the host if the agent-tui
process fails. This makes it impossible to debug the failure.

We want to start the agent-tui whenever tty1 exists (which in practice
seems to be always, even if there is only a serial console). To ensure
that we don't block subsequent login to the console after a failure, use
WantedBy instead of RequiredBy. The other install dependencies are not
needed.
@zaneb
Ensure cleanup after agent-tui failure
05728ad 
If agent-tui fails to start, we still want to switch back to the regular
VT and re-enable systemd status. Since ExecStartPost commands only run
if ExecStart succeeds, use ExecStopPost instead. This means disabling
RemainAfterExit (which is not needed anyway) so that the service also
stops on success.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 18, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-19037 has been cloned as Jira Issue OCPBUGS-19319. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-19319: Handle agent tui failure gracefully

In response to this:

This is an automated cherry-pick of #7490

/assign zaneb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-19037: Handle agent tui failure gracefully [release-4.14] OCPBUGS-19319: Handle agent tui failure gracefully Sep 18, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 18, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-19319, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-19037 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-19037 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @mhanss

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #7490

/assign zaneb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bfournie
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2023
@zaneb
Copy link
Member

zaneb commented Sep 18, 2023

/lgtm
/label backport-risk-assessed
/retest-required

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. labels Sep 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-gcp 05728ad link false /test okd-scos-e2e-gcp
ci/prow/e2e-agent-sno-ipv6 05728ad link false /test e2e-agent-sno-ipv6
ci/prow/e2e-agent-compact-ipv4-none-platform 05728ad link false /test e2e-agent-compact-ipv4-none-platform
ci/prow/okd-scos-e2e-vsphere 05728ad link false /test okd-scos-e2e-vsphere
ci/prow/okd-scos-e2e-gcp-ovn-upgrade 05728ad link false /test okd-scos-e2e-gcp-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zaneb
Copy link
Member

zaneb commented Sep 20, 2023

/assign @jhou1

@mhanss
Copy link
Contributor

mhanss commented Sep 26, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 26, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b1e1cad and 2 for PR HEAD 05728ad in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e18ceec and 1 for PR HEAD 05728ad in total

@openshift-merge-robot openshift-merge-robot merged commit 73beb52 into openshift:release-4.14 Sep 26, 2023
25 of 33 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-19319: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19319 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #7490

/assign zaneb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhanss mhanss Awaiting requested review from mhanss

@andfasano andfasano Awaiting requested review from andfasano

@bfournie bfournie Awaiting requested review from bfournie

Assignees

@zaneb zaneb

@jhou1 jhou1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @bfournie @zaneb @mhanss @jhou1 @openshift-merge-robot