OCPBUGS-12707: always write AWS cloud.conf #7514
Conversation
AWS Service endpoints are injected into the cloud.conf cloud-provider config by the cluster-config operator running on bootstrap, as described in: https://github.com/openshift/enhancements/blob/master/enhancements/installer/aws-custom-region-and-endpoints.md OCPBUGS-12707 occurs because the installer does not, by the design in the enhancement, write the service endpoints to the cloud config and there are no other uses of the config, so the installer does not populate the config at all. Accordingly, with no installer-generated config, the infrastructure object does not include a reference to the config. The bug occurs because the MCO's bootstrap mode rendering of the cloud provider config depends on the infrastructure object containing the name of the cloud.conf, but because that is not populated it produces an empty cloud.conf. Apparently the normal non-bootstrap mode differs and does correctly generate the cloud.conf. This causes an error because the MCO has a check to capture any drift between bootstrap and cluster. This bug can be resolved by always populating the empty cloud.conf, as it will correctly setup the cluster infrastructure object. It would also be possible to limit populating the cloud.conf only when service endpoints are set, but there is no reason to add extra gating logic.
openshift-ci-robot
added
jira/severity-critical
|
@patrickdillon: This pull request references Jira Issue OCPBUGS-12707, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/jira refresh |
|
@patrickdillon: This pull request references Jira Issue OCPBUGS-12707, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Will want to watch aws tests for regressions |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@r4f4: This pull request references Jira Issue OCPBUGS-12707, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: r4f4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
merged commit cb3289c
into
openshift:master
|
@patrickdillon: Jira Issue OCPBUGS-12707: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-12707 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.14 |
|
@patrickdillon: new pull request created: #7578 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
AWS Service endpoints are injected into the cloud.conf cloud-provider config by the cluster-config operator running on bootstrap, as described in:
https://github.com/openshift/enhancements/blob/master/enhancements/installer/aws-custom-region-and-endpoints.md
OCPBUGS-12707 occurs because the installer does not, by the design in the enhancement,
write the service endpoints to the cloud config and there are no other uses of the config, so the installer does not populate the config at all. Accordingly, with no installer-generated config, the infrastructure object does not include a reference to the config.
The bug occurs because the MCO's bootstrap mode rendering of the cloud provider config depends on the infrastructure object containing the name of the cloud.conf, but because that is not populated it produces an empty cloud.conf. Apparently the normal non-bootstrap mode differs and does correctly generate the cloud.conf. This causes an error because the MCO has a check to capture any drift between bootstrap and cluster.
This bug can be resolved by always populating the empty cloud.conf, as it will correctly setup the cluster infrastructure object. It would also be possible to limit populating the cloud.conf only when service endpoints are set, but there is no reason to add extra gating logic.