Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-24956: Add cloud credential capability validation #7875

Merged
merged 1 commit into from Jan 8, 2024
Merged

OCPBUGS-24956: Add cloud credential capability validation #7875

merged 1 commit into from Jan 8, 2024

Conversation

qJkee
Copy link
Contributor

@qJkee qJkee commented Jan 8, 2024

Add validation to the installer for CloudCredential capability in order to make it available only for baremetal installs or properly configured cloud credentials mode

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 8, 2024
@openshift-ci-robot
Copy link
Contributor

@qJkee: This pull request references Jira Issue OCPBUGS-24956, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add validation to the installer for CloudCredential capability in order to make it available only for baremetal installs or properly configured cloud credentials mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from rna-afk and sadasu January 8, 2024 14:09
patrickdillon
patrickdillon reviewed Jan 8, 2024
View reviewed changes
Copy link
Contributor

@patrickdillon patrickdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

This LGTM. one suggestion to see if it improves the error message.

Thanks for taking care of this!

pkg/types/validation/installconfig.go Outdated Show resolved Hide resolved
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@qJkee
Add cloud credential capability validation
784ff41 
Add validation to the installer for CloudCredential capability in order to make it available only for baremetal installs or properly configured cloud credentials mode
@qJkee
Copy link
Contributor Author

qJkee commented Jan 8, 2024

/retest

@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2024
@qJkee
Copy link
Contributor Author

qJkee commented Jan 8, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@qJkee: This pull request references Jira Issue OCPBUGS-24956, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 8, 2024

@qJkee: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qJkee
Copy link
Contributor Author

qJkee commented Jan 8, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 8, 2024
@openshift-ci-robot
Copy link
Contributor

@qJkee: This pull request references Jira Issue OCPBUGS-24956, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 8, 2024
@openshift-ci openshift-ci bot requested a review from gpei January 8, 2024 19:12
@openshift-merge-bot openshift-merge-bot bot merged commit 0b0271a into openshift:master Jan 8, 2024
22 checks passed
@openshift-ci-robot
Copy link
Contributor

@qJkee: Jira Issue OCPBUGS-24956: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-24956 has been moved to the MODIFIED state.

In response to this:

Add validation to the installer for CloudCredential capability in order to make it available only for baremetal installs or properly configured cloud credentials mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@qJkee
Copy link
Contributor Author

qJkee commented Jan 8, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 8, 2024
Closed
@openshift-cherrypick-robot
Copy link

@qJkee: new pull request created: #7880

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202401082351.p0.g0b0271a.assembly.stream for distgit ose-installer-altinfra.
All builds following this will include this PR.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jan 9, 2024
Merged
@qJkee qJkee mentioned this pull request Jan 9, 2024
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Jan 17, 2024
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-01-09-085011

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-01-14-231715

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-01-18-111941

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-01-21-092529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@rna-afk rna-afk Awaiting requested review from rna-afk

@sadasu sadasu Awaiting requested review from sadasu

@gpei gpei Awaiting requested review from gpei

Assignees

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@qJkee @openshift-ci-robot @patrickdillon @openshift-cherrypick-robot @openshift-bot @openshift-merge-robot