Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15]OCPBUGS-26495: Add cloud credential capability validation #7890

Merged
merged 2 commits into from Jan 11, 2024
Merged

[release-4.15]OCPBUGS-26495: Add cloud credential capability validation #7890

merged 2 commits into from Jan 11, 2024

Conversation

qJkee
Copy link
Contributor

@qJkee qJkee commented Jan 9, 2024

Manual backport of #7884 and #7875

@qJkee
Add cloud credential capability validation
90f1b9f 
Add validation to the installer for CloudCredential capability in order to make it available only for baremetal installs or properly configured cloud credentials mode
@qJkee
Add cloud credential capability validation
9bf6fd8 
disabling cloud credential available only for baremetal clusters
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 9, 2024
@openshift-ci-robot
Copy link
Contributor

@qJkee: This pull request references Jira Issue OCPBUGS-26495, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-24956 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-24956 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @jinyunma

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual backport of #7884 and #7875

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@qJkee
Copy link
Contributor Author

qJkee commented Jan 10, 2024

/retest

fxierh
fxierh reviewed Jan 10, 2024
View reviewed changes
Copy link

@fxierh fxierh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installconfig.go looks good.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

@qJkee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-gcp-ovn-upgrade 9bf6fd8 link false /test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/okd-scos-e2e-vsphere 9bf6fd8 link false /test okd-scos-e2e-vsphere
ci/prow/okd-scos-e2e-gcp 9bf6fd8 link false /test okd-scos-e2e-gcp
ci/prow/e2e-vsphere-static-ovn 9bf6fd8 link false /test e2e-vsphere-static-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2024
@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@gpei
Copy link
Contributor

gpei commented Jan 11, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 81a041f into openshift:release-4.15 Jan 11, 2024
27 of 31 checks passed
@openshift-ci-robot
Copy link
Contributor

@qJkee: Jira Issue OCPBUGS-26495: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26495 has been moved to the MODIFIED state.

In response to this:

Manual backport of #7884 and #7875

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.15.0-202401110249.p0.g81a041f.assembly.stream for distgit ose-installer-altinfra.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-01-13-050900

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jan 18, 2024
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-01-22-051500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxierh fxierh fxierh left review comments

@jinyunma jinyunma Awaiting requested review from jinyunma

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

@r4f4 r4f4 Awaiting requested review from r4f4

Assignees

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@qJkee @openshift-ci-robot @patrickdillon @gpei @openshift-bot @openshift-merge-robot @fxierh