CNF-10170: bootkube.sh: Render kernel boot arguments for SNO #8007
Conversation
In an effort to speed up installation and avoid node reboots this command will run `tuneD` on a properly isolated environment and render a MachineConfig to apply the kernel boot args readed from `/etc/tuned/bootcmdline` Signed-off-by: Jose Luis Ojosnegros Manchón <jojosneg@redhat.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@jlojosnegros: This pull request references CNF-10170 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.15" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test okd-e2e-aws-ovn-upgrade |
4 similar comments
|
/test okd-e2e-aws-ovn-upgrade |
|
/test okd-e2e-aws-ovn-upgrade |
|
/test okd-e2e-aws-ovn-upgrade |
|
/test okd-e2e-aws-ovn-upgrade |
|
/retest |
|
/test okd-e2e-aws-ovn-upgrade |
| tmpfolder=$(mktemp -d) | ||
| echo ${tmpfolder} | ||
| podmancmd="bootkube_podman_run --attach=stderr --rm " | ||
| for folder in var/lib/tuned/profile-data etc/modprobe.d etc/sysconfig etc/kubernetes etc/sysctl.d etc/systemd run sys lib/modules var/lib/kubelet usr/lib/tuned etc/tuned; do |
There was a problem hiding this comment.
@jmencak @jlojosnegros do we need to align with openshift/cluster-node-tuning-operator#970 in some manner ? or that change is not affecting the installer ?
There was a problem hiding this comment.
Good point. It looks like it needs an update. Also note that /var/lib/tuned/profiles-data was removed, not sure what var/lib/tuned/profile-data (singular) is used for. @jlojosnegros typo?
There was a problem hiding this comment.
yeah it is a typo
|
/test okd-e2e-aws-ovn-upgrade |
|
@jlojosnegros: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close |
|
@vitus133: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In an effort to speed up installation and avoid node reboots this command will run
tuneDon a properly isolated environment and render a MachineConfig to apply the kernel boot args readed from/etc/tuned/bootcmdlinereverts: #7979
See: