Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNF-10170: Avoid command to fail if there is no PP on input folders #935

Merged
merged 1 commit into from Feb 26, 2024
Merged

CNF-10170: Avoid command to fail if there is no PP on input folders #935

merged 1 commit into from Feb 26, 2024

Conversation

jlojosnegros
Copy link
Contributor

@jlojosnegros jlojosnegros commented Feb 5, 2024 •
edited

When there is no enough information to choose a recommended TuneD profile from the input folder manifests we load the default-cr-tuned manifests.

modifies: #844
see: openshift/installer#8007

@jlojosnegros jlojosnegros changed the title Read default tuned profiles from file system CNF-10170: Read default tuned profiles from file system Feb 5, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 5, 2024 •
edited by openshift-ci bot

@jlojosnegros: This pull request references CNF-10170 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.15" instead.

In response to this:

To be able to choose properly the recommended profile we need to have the default tuned profiles loaded.
As this command is intended to be run in bootstrap we need to read them from the file system.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 5, 2024
@jlojosnegros
Copy link
Contributor Author

/cc @MarSik @vitus133

@jlojosnegros
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2024
jlojosnegros
jlojosnegros commented Feb 7, 2024
View reviewed changes
pkg/util/manifests.go Outdated Show resolved Hide resolved
@jlojosnegros jlojosnegros changed the title CNF-10170: Read default tuned profiles from file system CNF-10170: Avoid command to fail if there is no PP on input folders Feb 9, 2024
@jlojosnegros
Copy link
Contributor Author

/test e2e-hypershift

@jlojosnegros jlojosnegros force-pushed the read-default-tuned branch 2 times, most recently from 05bec0c to 2090060 Compare February 13, 2024 11:07
@jlojosnegros jlojosnegros mentioned this pull request Feb 13, 2024
Closed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 13, 2024 •
edited by openshift-ci bot

@jlojosnegros: This pull request references CNF-10170 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.15" instead.

In response to this:

When there is no enough information to choose a recommended TuneD profile from the input folder manifests we load the default-cr-tuned manifests.

modifies: #844
see: openshift/installer#8007

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jlojosnegros
Copy link
Contributor Author

/test e2e-aws-ovn-techpreview

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlojosnegros, MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2024
@jlojosnegros
Render: Don't fail if there is no recommended profile.
ef12f0c 
Use `default-cr-tuned` as default

Signed-off-by: Jose Luis Ojosnegros Manchón <jojosneg@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2024
@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 14, 2024
Merged
@MarSik
Copy link
Contributor

MarSik commented Feb 15, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
@jlojosnegros
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d7c3111 and 2 for PR HEAD ef12f0c in total

@vitus133
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2024
@jlojosnegros
Copy link
Contributor Author

/hold
@vitus133 found a possible issue -> reviewing

@vitus133
Copy link
Contributor

/retest
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2024
@vitus133
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD abfe492 and 1 for PR HEAD ef12f0c in total

@vitus133
Copy link
Contributor

/test e2e-hypershift

1 similar comment
@jlojosnegros
Copy link
Contributor Author

/test e2e-hypershift

@jlojosnegros
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 19686cd and 0 for PR HEAD ef12f0c in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision ef12f0c was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2024
@jlojosnegros
Copy link
Contributor Author

/test e2e-aws-ovn-techpreview
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 19686cd and 2 for PR HEAD ef12f0c in total

@yanirq
Copy link
Contributor

yanirq commented Feb 26, 2024

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

@jlojosnegros: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e7ff8d5 into openshift:master Feb 26, 2024
15 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202402261639.p0.ge7ff8d5.assembly.stream.el9 for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

@vitus133 vitus133 mentioned this pull request Mar 5, 2024
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 13, 2024
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2024-03-19-212806

Tal-or pushed a commit to Tal-or/cluster-node-tuning-operator that referenced this pull request Apr 1, 2024
@jlojosnegros @Tal-or
Render: Don't fail if there is no recommended profile. (openshift#935)
1c06e3f 
Use `default-cr-tuned` as default

Signed-off-by: Jose Luis Ojosnegros Manchón <jojosneg@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarSik MarSik MarSik approved these changes

@swatisehgal swatisehgal Awaiting requested review from swatisehgal

@Tal-or Tal-or Awaiting requested review from Tal-or

@vitus133 vitus133 Awaiting requested review from vitus133

Assignees

@MarSik MarSik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jlojosnegros @openshift-ci-robot @MarSik @vitus133 @yanirq @openshift-bot @openshift-merge-robot