Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLAT-1460: Make vSphere default ResourcePool formatting not contain double slash. #8044

Merged
merged 1 commit into from
Mar 6, 2024
Merged

SPLAT-1460: Make vSphere default ResourcePool formatting not contain double slash. #8044

merged 1 commit into from
Mar 6, 2024

Conversation

vr4manta
Copy link
Contributor

SPLAT-1460

Changes

  • Modified default ResourcePool definition to prevent double "/" in path

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 19, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 19, 2024 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-1460 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

SPLAT-1460

Changes

  • Modified default ResourcePool definition to prevent double "/" in path

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2024
@jcpowermac
Copy link
Contributor

/approve
/hold

@vr4manta remove the hold whenever you feel like this is ready

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 19, 2024
@vr4manta
Copy link
Contributor Author

/test e2e-vsphere-static-ovn

@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 19, 2024
@vr4manta
Copy link
Contributor Author

/retest

@vr4manta
Copy link
Contributor Author

/assign @rwsu
Ready for review. Thanks!

@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
@vr4manta
Copy link
Contributor Author

/retest

@vr4manta
Copy link
Contributor Author

/test e2e-agent-compact-ipv4

@vr4manta
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2024
@vr4manta
Copy link
Contributor Author

/retest-required

rwsu
rwsu approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, rwsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
@openshift-ci-robot
Copy link
Contributor

/hold

Revision 2208499 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 29, 2024
@vr4manta
Copy link
Contributor Author

/retest-required

@vr4manta
Copy link
Contributor Author

vr4manta commented Mar 1, 2024

/test e2e-vsphere-ovn

1 similar comment
@vr4manta
Copy link
Contributor Author

vr4manta commented Mar 1, 2024

/test e2e-vsphere-ovn

@vr4manta
Copy link
Contributor Author

vr4manta commented Mar 1, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9552fc8 and 2 for PR HEAD 2208499 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1a50ad3 and 1 for PR HEAD 2208499 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD bc0cd0a and 0 for PR HEAD 2208499 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 2208499 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2024
@vr4manta
Copy link
Contributor Author

vr4manta commented Mar 4, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2024
@andfasano
Copy link
Contributor

/override ci/prow/e2e-agent-compact-ipv4

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 4, 2024

@andfasano: Overrode contexts on behalf of andfasano: ci/prow/e2e-agent-compact-ipv4

In response to this:

/override ci/prow/e2e-agent-compact-ipv4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor

/skip

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7e4d988 and 2 for PR HEAD 2208499 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b569901 and 1 for PR HEAD 2208499 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e527352 and 0 for PR HEAD 2208499 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 5, 2024 •
edited
Loading

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4-appliance 2208499 link false /test e2e-agent-compact-ipv4-appliance
ci/prow/okd-e2e-aws-ovn-upgrade 2208499 link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 2208499 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2024
@vr4manta
Copy link
Contributor Author

vr4manta commented Mar 5, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e527352 and 2 for PR HEAD 2208499 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 7db246e into openshift:master Mar 6, 2024
36 checks passed
@vr4manta
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 26, 2024
Merged
@openshift-cherrypick-robot
Copy link

@vr4manta: new pull request created: #8664

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwsu rwsu rwsu approved these changes

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@rwsu rwsu

@jcpowermac jcpowermac

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vr4manta @openshift-ci-robot @jcpowermac @patrickdillon @andfasano @openshift-cherrypick-robot @rwsu