OCPBUGS-29895: PowerVS: Add debugging to ServiceInstanceNameToGUID

[hamzy]

A user noticed on delete cluster that the IPI generated service instance was not cleaned up. Add more debugging statements to find out why.

[hamzy]

@r4f4 What do you think about a PR that just adds debugging statements? Someone was verifying a previous PR and encountered a bug. Looking at the logs, I couldn't narrow it down to a clear failing condition.

[r4f4]

@r4f4 What do you think about a PR that just adds debugging statements? Someone was verifying a previous PR and encountered a bug. Looking at the logs, I couldn't narrow it down to a clear failing condition.

Not opposed to it but it would better if they could build a release from this PR without merging it if you don't intend for the debug logs to stay.

[hamzy]

Not opposed to it but it would better if they could build a release from this PR without merging it if you don't intend for the debug logs to stay.

I do intend the logs to stay in case similar problems surface in the future. I also plan on cherry picking it into 4.15. Does that sound reasonable?

[r4f4]

Not opposed to it but it would better if they could build a release from this PR without merging it if you don't intend for the debug logs to stay.

I do intend the logs to stay in case similar problems surface in the future. I also plan on cherry picking it into 4.15. Does that sound reasonable?

Then you'll need a bug for this PR.

[openshift-ci-robot]

@hamzy: This pull request references Jira Issue OCPBUGS-29895, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

A user noticed on delete cluster that the IPI generated service instance was not cleaned up. Add more debugging statements to find out why.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[hamzy]

/jira refresh

[openshift-ci-robot]

@hamzy: This pull request references Jira Issue OCPBUGS-29895, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[r4f4]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [r4f4]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mjturek]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9978285 and 2 for PR HEAD 11d4ab8 in total

[openshift-ci]

@hamzy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@hamzy: Jira Issue OCPBUGS-29895: All pull requests linked via external trackers have merged:

• openshift/installer#8058

Jira Issue OCPBUGS-29895 has been moved to the MODIFIED state.

In response to this:

A user noticed on delete cluster that the IPI generated service instance was not cleaned up. Add more debugging statements to find out why.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[hamzy]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@hamzy: new pull request created: #8065

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202402270439.p0.g51ee838.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-02-29-062601