-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS-3195: Azure CAPI Supplemental Load Balancers #8115
CORS-3195: Azure CAPI Supplemental Load Balancers #8115
Conversation
@patrickdillon: This pull request references CORS-3195 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
710349c
to
d4b12fb
Compare
d4b12fb
to
197369b
Compare
@patrickdillon: This pull request references CORS-3195 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1b45d58
to
18c3c1c
Compare
d610182
to
3d5d101
Compare
There are some gofmt and golint errors. Other than that, everything LGTM. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhixson74 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2d34945
to
7f2b833
Compare
Adding a ControlPlaneOutboundLB to allow outbound access to the bootstrap node:
and adding the bootstrap ignition commits, this enables control plane nodes to pull ignition Note that adding this precludes you from adding a public ip to the VM (a vm with a public ip config cannot have an outbound rule). |
7f2b833
to
49e39d9
Compare
/retest |
a79084b
to
ea75eba
Compare
As part of the cluster-api-based Azure installation flow this configures the CAPZ-created internal load balancer to serve ignition to control plane machines. It also creates an external load balancer when the cluster is public.
Adds armnetwork packages, for working with load balancers.
go mod vendor
ea75eba
to
1eb9d4f
Compare
/retest @jhixson74 I think the linting issues are fixed |
/retest |
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
ac3ac89
into
openshift:master
[ART PR BUILD NOTIFIER] This PR has been included in build ose-installer-altinfra-container-v4.16.0-202404031748.p0.gac3ac89.assembly.stream.el8 for distgit ose-installer-altinfra. |
Created kubernetes-sigs/cluster-api-provider-azure#4755 to track implementing dual load balancer/endpoint logic upstream (a 4.17 concern), as well as creating OCPCLOUD-2588 |
Adds support for creating an additional, external LB. As well as updating the capi-provisioned internal LB with config for the machine-config server.
/cc @rna-afk @jhixson74