Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: Document changes since v0.5.0 #841

Merged
merged 1 commit into from
Dec 11, 2018

Conversation

wking
Copy link
Member

@wking wking commented Dec 7, 2018

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 7, 2018
@abhinavdahiya
Copy link
Contributor

/approve

@wking
Copy link
Member Author

wking commented Dec 8, 2018

/retest

Give me a CI cluster so I can poke around with why e2e-aws is borked.

@wking
Copy link
Member Author

wking commented Dec 10, 2018

I've pushed dcc8077 -> eeca4c2, bumping the target release date to today.

/hold

There are a few minor changes I want to get in first (#793, #834, #840, and #849), but I think they'd all fall under "Lots of doc and internal cleanup and minor fixes". @abhinavdahiya, @crawford, can I get a /lgtm here? I'd like to be able to land this once we get those PRs merged without anyone else having to stay up late ;).

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2018
@crawford
Copy link
Contributor

Do we also want #822?

@crawford
Copy link
Contributor

/retest

@crawford
Copy link
Contributor

Needs additional changes from 819ecb3.

@wking wking force-pushed the version-0.6.0 branch 2 times, most recently from 9159aaf to 414b8c8 Compare December 10, 2018 22:56
@wking
Copy link
Member Author

wking commented Dec 10, 2018

I've pushed eeca4c2 -> 414b8c8, rebasing onto master now that #822 has landed. I've picked up the Terraform entry from 819ecb3. I've also added an additional Unreleased section so I can talk about #791, which has landed in master but which wasn't part of 0.6.0.

CHANGELOG.md Outdated Show resolved Hide resolved
@wking wking force-pushed the version-0.6.0 branch 3 times, most recently from 54f3b4a to 05ba0fa Compare December 10, 2018 23:02
@crawford
Copy link
Contributor

+1 to the unreleased section. Let's encourage the team to write our own change log instead of relying on @wking.

@wking
Copy link
Member Author

wking commented Dec 10, 2018

+1 to the unreleased section. Let's encourage the team to write our own change log instead of relying on @wking

The drawback to that is that it's a source of merge conflicts for otherwise orthogonal changes. Middle ground is something like Kube's fenced release-note, and I'd be fine moving to something like that.

@wking
Copy link
Member Author

wking commented Dec 10, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2018
Through e810901 (Merge pull request openshift#817 from
staebler/add_openshiftClusterID, 2018-12-10, openshift#822).
@wking
Copy link
Member Author

wking commented Dec 11, 2018

Rebased onto master with 05ba0fa -> 08e4dbc, to document #817. Now that we've emptied the LGTM backlog 🎉, I think we want to land this so we can start preparing for 0.7.0 :).

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member Author

wking commented Dec 11, 2018

e2e-aws:

level=fatal msg="Error executing openshift-install: waiting for bootstrap-complete: timed out waiting for the condition"

As discused in #857, that could be a number of things, but I haven't dug through the CI artifacts to try and pin it down.

@openshift-merge-robot openshift-merge-robot merged commit fb40d02 into openshift:master Dec 11, 2018
@wking wking deleted the version-0.6.0 branch December 11, 2018 10:50
wking added a commit to wking/openshift-installer that referenced this pull request Dec 14, 2018
Covering 08e4dbc (CHANGELOG: Document changes since v0.5.0,
2018-12-07, openshift#841) through 5813f61 (Merge pull request openshift#745 from
wking/s3-vpc-endpoint, 2018-12-13).
wking added a commit to wking/openshift-installer that referenced this pull request Dec 14, 2018
Covering 08e4dbc (CHANGELOG: Document changes since v0.5.0,
2018-12-07, openshift#841) through 5813f61 (Merge pull request openshift#745 from
wking/s3-vpc-endpoint, 2018-12-13).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants