Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: Document changes since 2018-12-07 #906

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

wking
Copy link
Member

@wking wking commented Dec 14, 2018

Covering 08e4dbc (#841) through 5813f61 (#745), and setting us up for a v0.7.0 tomorrow. We probably don't want to land this until we're about to cut the release, in case we want to land additional changes before that, but I thought I'd put the PR up so folks could review the bulk of the entries.

@flaper87, do you want to double-check my attempt at sumarizing #854? I don't know what else lives in OpenStack cloud configs, so the wording I have now reads something like "now we only inject the clouds part of the cloud config". Dunno if that could be reworded to be a bit more clear or not.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 14, 2018
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2018
CHANGELOG.md Outdated Show resolved Hide resolved
Covering 08e4dbc (CHANGELOG: Document changes since v0.5.0,
2018-12-07, openshift#841) through 5813f61 (Merge pull request openshift#745 from
wking/s3-vpc-endpoint, 2018-12-13).
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 17c7e3f into openshift:master Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants