Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2086759: Bump retries for UEFI boot configuration #47

Merged
merged 1 commit into from
May 16, 2022

Conversation

derekhiggins
Copy link

Testing proved to need more retries on the HW where we could
reproduce this problem

Testing proved to need more retries on the HW where we could
reproduce this problem
@openshift-ci openshift-ci bot requested review from dtantsur and zaneb May 16, 2022 11:31
@openshift-ci
Copy link

openshift-ci bot commented May 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2022
@derekhiggins derekhiggins changed the title Bump retries for UEFI boot configuration Bug 2086759: Bump retries for UEFI boot configuration May 16, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 16, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 16, 2022

@derekhiggins: This pull request references Bugzilla bug 2086759, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "4.10.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2086759: Bump retries for UEFI boot configuration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekhiggins
Copy link
Author

/bugzilla refresh
I'll submit upstream if this proves to fix the problem.

@openshift-ci
Copy link

openshift-ci bot commented May 16, 2022

@derekhiggins: This pull request references Bugzilla bug 2086759, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "4.10.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh
I'll submit upstream if this proves to fix the problem.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekhiggins
Copy link
Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 16, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 16, 2022

@derekhiggins: This pull request references Bugzilla bug 2086759, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekhiggins
Copy link
Author

/test e2e-metal-ipi

@dtantsur
Copy link
Member

/lgtm

We can merge it, but it doesn't feel right. Is there something we can wait for instead? Can we maybe significantly bump the retries of test -e in IPA proper? Let's try to revisit it for 4.12.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2022
@derekhiggins
Copy link
Author

/test e2e-metal-ipi

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented May 16, 2022

@derekhiggins: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack 18fed35 link false /test e2e-metal-ipi-ovn-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit fd673bf into openshift:main May 16, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 16, 2022

@derekhiggins: All pull requests linked via external trackers have merged:

Bugzilla bug 2086759 has been moved to the MODIFIED state.

In response to this:

Bug 2086759: Bump retries for UEFI boot configuration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekhiggins
Copy link
Author

/cherry-pick release-4.10

@openshift-cherrypick-robot

@derekhiggins: #47 failed to apply on top of branch "release-4.10":

Applying: Bump retries for UEFI boot configuration
Using index info to reconstruct a base tree...
M	hardware_manager/ironic_coreos_install.py
Falling back to patching base and 3-way merge...
Auto-merging hardware_manager/ironic_coreos_install.py
CONFLICT (content): Merge conflict in hardware_manager/ironic_coreos_install.py
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bump retries for UEFI boot configuration
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants