-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1916145: Explicitly set minimum versions of python libraries #56
Bug 1916145: Explicitly set minimum versions of python libraries #56
Conversation
To simplify keeping track of minimum installed and required version of python libraries and ironic packages, we add the versions in the packages list. This will also help when cross-tagging packages to test with the new versions using the prevalidation repositories.
@elfosardo: This pull request references Bugzilla bug 1916145, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation |
/bugzilla refresh |
@elfosardo: This pull request references Bugzilla bug 1916145, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/retest |
2 similar comments
/retest |
/retest |
/test images |
/test e2e-metal-ipi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -3,7 +3,7 @@ | |||
set -ex | |||
|
|||
dnf upgrade -y | |||
dnf install -y $(cat /tmp/main-packages-list.txt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could just surround $(cat ..) with quotes
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@elfosardo: All pull requests linked via external trackers have merged: Bugzilla bug 1916145 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
To simplify keeping track of minimum installed and required version
of python libraries and ironic packages, we add the versions in
the packages list.
This will also help when cross-tagging packages to test with the
new versions using the prevalidation repositories.