Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1863390: Use dnf to install packages in the ipa ramdisk #37

Merged
merged 1 commit into from Aug 26, 2020
Merged

Bug 1863390: Use dnf to install packages in the ipa ramdisk #37

merged 1 commit into from Aug 26, 2020

Conversation

elfosardo
Copy link

@elfosardo elfosardo commented Jul 30, 2020 •
edited

Move the logic to modify the ipa-ramdisk to the chrooted.sh script
that is executed in a chroot environment.
This allows us to use native commands directly in the ipa-ramdisk
image, like dnf, and exit correctly in case of failures.
Also provide a list of packages installed in the ipa-ramdisk.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
dhellmann
dhellmann reviewed Jul 30, 2020
View reviewed changes
build-ipa.sh Outdated Show resolved Hide resolved
@elfosardo
Copy link
Author

/retest

@elfosardo elfosardo force-pushed the dnf-ftw branch 3 times, most recently from 9ab91cf to ee852f6 Compare July 31, 2020 18:29
@elfosardo
Copy link
Author

/retest

dtantsur
dtantsur approved these changes Aug 3, 2020
View reviewed changes
build-ipa.sh
chmod +x /etc/NetworkManager/dispatcher.d/01-hostname
# Prepare the chroot environment
cp /etc/resolv.conf etc/resolv.conf
mv etc/yum.repos.d/* .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Let's use a temporary directory rather than root

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're using a temp dir as root, see L12
also I will have to pass the tmpdir to the chroot env as I'm keeping the cleaning steps there, where we put back the original repos

chrooted.sh Outdated Show resolved Hide resolved
chrooted.sh Outdated Show resolved Hide resolved
@elfosardo elfosardo changed the title Use dnf to install packages in the ipa ramdisk Bug 1863390: Use dnf to install packages in the ipa ramdisk Aug 3, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 3, 2020
@openshift-ci-robot
Copy link

@elfosardo: This pull request references Bugzilla bug 1863390, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1863390: Use dnf to install packages in the ipa ramdisk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2020
@elfosardo
Copy link
Author

/retest

@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 18, 2020
Merged
@elfosardo elfosardo force-pushed the dnf-ftw branch 3 times, most recently from bdbe913 to 7446a70 Compare August 19, 2020 12:40
@elfosardo
Copy link
Author

/retest

1 similar comment
@elfosardo
Copy link
Author

/retest

@elfosardo
Use dnf to install packages in the ipa ramdisk
944c089 
Move the logic to modify the ipa-ramdisk to the chrooted.sh script
that is executed in a chroot environment.
This allows us to use native commands directly in the ipa-ramdisk
image, like dnf, and exit correctly in case of failures.
Also provide a list of packages installed in the ipa-ramdisk.
@elfosardo
Copy link
Author

/retest

1 similar comment
@elfosardo
Copy link
Author

/retest

dtantsur
dtantsur approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins, dtantsur, elfosardo, iurygregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [derekhiggins,dtantsur,elfosardo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elfosardo
Copy link
Author

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 06625df into openshift:master Aug 26, 2020
@openshift-ci-robot
Copy link

@elfosardo: All pull requests linked via external trackers have merged:

Bugzilla bug 1863390 has been moved to the MODIFIED state.

In response to this:

Bug 1863390: Use dnf to install packages in the ipa ramdisk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekhiggins derekhiggins derekhiggins left review comments

@dtantsur dtantsur dtantsur approved these changes

@iurygregory iurygregory iurygregory approved these changes

@hardys hardys Awaiting requested review from hardys

@dhellmann dhellmann Awaiting requested review from dhellmann

@stbenjam stbenjam Awaiting requested review from stbenjam

@bfournie bfournie Awaiting requested review from bfournie

@juliakreger juliakreger Awaiting requested review from juliakreger

Assignees

@dtantsur dtantsur

@derekhiggins derekhiggins

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet