Bug 1863390: Fix arch for python3-bcrypt #39
Conversation
openshift-ci-robot
added
the
approved
elfosardo
requested review from
dtantsur,
iurygregory,
bfournie,
derekhiggins and
stbenjam
and removed request for
dhellmann
|
/retest |
1 similar comment
|
/retest |
elfosardo
changed the title
openshift-ci-robot
added
the
bugzilla/severity-urgent
|
@elfosardo: This pull request references Bugzilla bug 1863390, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
Dockerfile.ocp
Outdated
| @@ -13,7 +13,7 @@ RUN dnf upgrade -y && \ | |||
| && \ | |||
| dnf download --destdir /tmp/packages \ | |||
| openstack-ironic-python-agent \ | |||
| python3-bcrypt \ | |||
| python3-bcrypt.x86_64 \ | |||
There was a problem hiding this comment.
Any idea how OCP multi-arch builds work? I assume some variable is passed in at build time, so I wonder can we find an example of that and do the same here to avoid hard-coding?
There was a problem hiding this comment.
Or I see we're using $(uname -m) to determine the arch for the IPA RPM, can we do the same here?
There was a problem hiding this comment.
We need to hard-code here because we're installing in ipa-ramdisk which is x86-64 only
Unfortunately in the images both x86-64 and ppc64 repositories are included, which is ok if we need to control only what's installed on the image itself.
In case we need to do something exotic (like this case or like the builder in the ironic image), we have to force the arch.
There was a problem hiding this comment.
scratch that, I forgot we also build (and install) ipa-ramdisk natively on ppc64, so we need to change arch to variable, not hard-code it
thanks for that!
The python3-bcrypt library is going to be installed inside the ipa-ramdisk based on its architecture.
|
@elfosardo: This pull request references Bugzilla bug 1863390, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo, hardys, iurygregory The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@elfosardo: Some pull requests linked via external trackers have merged: openshift/ironic-ipa-downloader#39. The following pull requests linked via external trackers have not merged:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The python3-bcrypt library is going to be installed inside the
ipa-ramdisk based on its architecture.