-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't compress the RHCOS image #60
Merged
openshift-merge-robot
merged 1 commit into
openshift:master
from
derekhiggins:no-convert
Sep 9, 2021
Merged
Don't compress the RHCOS image #60
openshift-merge-robot
merged 1 commit into
openshift:master
from
derekhiggins:no-convert
Sep 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Aug 27, 2021
openshift-ci
bot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Aug 27, 2021
/uncc |
/retest |
derekhiggins
force-pushed
the
no-convert
branch
3 times, most recently
from
August 31, 2021 13:09
7d649fd
to
aef0fec
Compare
derekhiggins
changed the title
[WIP]Don't compress the RHCOS image
Don't compress the RHCOS image
Aug 31, 2021
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Aug 31, 2021
derekhiggins
force-pushed
the
no-convert
branch
from
September 1, 2021 09:37
aef0fec
to
2b70194
Compare
This compression was added years ago so that IPA running in developemnt environments with limited RAM could download the image to a tmpfs. It added 2 to 3 minutes and at the time we cached the image (masters downloaded it from the bootstrap VM), so it was a single hit. Fast forward to today, we've removed the caching and now run an additional image-cache pod on each master. So we're running this 5 times(at least 3 in series). And the default dev env requirments is now 8G for worker nodes meaning its not needed any longer and removing it should reduce the time taken to get a running cluster by about 8 minutes.
derekhiggins
force-pushed
the
no-convert
branch
from
September 8, 2021 15:20
2b70194
to
6ea431d
Compare
/test e2e-metal-ipi-virtualmedia |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekhiggins, dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This compression was added years ago so that IPA running in developemnt
environments with limited RAM could download the image to a tmpfs. It
added 2 to 3 minutes and at the time we cached the image (masters downloaded
it from the bootstrap VM), so it was a single hit.
Fast forward to today, we've removed the caching and now run an additional
image-cache pod on each master. So we're running this 5 times(at least 3 in series).
And the default dev env requirments is now 8G for worker nodes meaning its not needed
any longer.