Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't compress the RHCOS image #60

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

derekhiggins
Copy link
Contributor

@derekhiggins derekhiggins commented Aug 27, 2021

This compression was added years ago so that IPA running in developemnt
environments with limited RAM could download the image to a tmpfs. It
added 2 to 3 minutes and at the time we cached the image (masters downloaded
it from the bootstrap VM), so it was a single hit.

Fast forward to today, we've removed the caching and now run an additional
image-cache pod on each master. So we're running this 5 times(at least 3 in series).
And the default dev env requirments is now 8G for worker nodes meaning its not needed
any longer.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2021
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2021
@dhellmann
Copy link

/uncc

@openshift-ci openshift-ci bot removed the request for review from dhellmann August 27, 2021 16:19
@derekhiggins
Copy link
Contributor Author

/retest

@derekhiggins derekhiggins force-pushed the no-convert branch 3 times, most recently from 7d649fd to aef0fec Compare August 31, 2021 13:09
@derekhiggins derekhiggins changed the title [WIP]Don't compress the RHCOS image Don't compress the RHCOS image Aug 31, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2021
This compression was added years ago so that IPA running in developemnt
environments with limited RAM could download the image to a tmpfs. It
added 2 to 3 minutes and at the time we cached the image (masters downloaded
it from the bootstrap VM), so it was a single hit.

Fast forward to today, we've removed the caching and now run an additional
image-cache pod on each master. So we're running this 5 times(at least 3 in series).
And the default dev env requirments is now 8G for worker nodes meaning its not needed
any longer and removing it should reduce the time taken to get a running cluster
by about 8 minutes.
@derekhiggins
Copy link
Contributor Author

/test e2e-metal-ipi-virtualmedia

@dtantsur
Copy link
Member

dtantsur commented Sep 9, 2021

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins, dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [derekhiggins,dtantsur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2021
@openshift-merge-robot openshift-merge-robot merged commit 9319a81 into openshift:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants