Bug 2005805: Clear proxy env variables if go would have

[derekhiggins]

Clear proxy env variables if go would have

curl interpretes the various proxy related env variables
differently to the golang http library. Add a small utility
to test what golang would have done and clear the proxy
variables if appropriate.

This will better match how proxies are handled in the cluster
and whats documented.

Also cherry-pick of af79eb4 which
changes where the utility if built (so it doesn't break in ART)

[openshift-ci]

@derekhiggins: This pull request references Bugzilla bug 2005805, which is invalid:

• expected Bugzilla bug 2005805 to depend on a bug targeting a release in 4.9.0, 4.9.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2005805: Clear proxy env variables if go would have

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[derekhiggins]

/bugzilla refresh

[openshift-ci]

@derekhiggins: This pull request references Bugzilla bug 2005805, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.8.z) matches configured target release for branch (4.8.z)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2020546 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2020546 targets the "4.9.z" release, which is one of the valid target releases: 4.9.0, 4.9.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (vvoronko@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[derekhiggins]

Will also need openshift-eng/ocp-build-data#1169

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [derekhiggins]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dtantsur]

/lgtm
/label backport-risk-assessed

[sosiouxme]

openshift-eng/ocp-build-data#1169 is followup for ART config

[lshilin-r]

/label cherry-pick-approved

[openshift-ci]

@derekhiggins: All pull requests linked via external trackers have merged:

• openshift/ironic-rhcos-downloader#72

Bugzilla bug 2005805 has been moved to the MODIFIED state.

In response to this:

Bug 2005805: Clear proxy env variables if go would have

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[elfosardo]

/cherry-pick release-4.7

[openshift-cherrypick-robot]

@elfosardo: #72 failed to apply on top of branch "release-4.7":

Applying: Clear proxy env variables if go would have
Using index info to reconstruct a base tree...
M	Dockerfile.ocp
M	get-resource.sh
Falling back to patching base and 3-way merge...
Auto-merging get-resource.sh
CONFLICT (content): Merge conflict in get-resource.sh
Auto-merging Dockerfile.ocp
CONFLICT (content): Merge conflict in Dockerfile.ocp
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Clear proxy env variables if go would have
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ironic-rhcos-downloader-container-v4.8.0-202311261141.p0.gdceaf13.assembly.stream for distgit ironic-rhcos-downloader.
All builds following this will include this PR.