add first class rsh, better deal with args for proxy cmds like exec, rsh #81
Conversation
|
[test] |
openshift-ci-robot
added
the
size/S
|
|
||
| cmd.addAll(toStringArray(userArgs)); | ||
|
|
||
| cmd.addAll(toStringArray(options)); |
There was a problem hiding this comment.
this is just ensuring that the "--" arg does not come before the "--loglevel" or other args being added?
There was a problem hiding this comment.
ah ... i should update the comment, forgot that the literal -- sequence could be a valid arg
what I was trying to convey was that things like --server, --namespace, --token, --loglevel in the wrong position would confuse oc rsh ... that is what was causing the problem .... moving those args prior to the verb works generically, and protects oc rsh
There was a problem hiding this comment.
got it, yeah a clarifying comment would help, otherwise lgtm.
There was a problem hiding this comment.
comment clarified
|
[merge] |
|
Evaluated for jenkins client plugin test up to 4cfdbd8 |
|
Evaluated for jenkins client plugin merge up to 4cfdbd8 |
|
continuous-integration/openshift-jenkins-client-plugin/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_jenkins_client_plugin/7/) (Base Commit: 5c823bc) (PR Branch Commit: 4cfdbd8) (Image: devenv-rhel7_8) |
|
continuous-integration/openshift-jenkins-client-plugin/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_jenkins_client_plugin/20/) (Base Commit: 5c823bc) (PR Branch Commit: 4cfdbd8) |
Merged by openshift-bot
ghost
mentioned this pull request
Fixes #79
@openshift/sig-developer-experience fyi