Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added rsync #91

Merged
merged 2 commits into from Dec 4, 2017
Merged

added rsync #91

merged 2 commits into from Dec 4, 2017

Conversation

ghost
Copy link

@ghost ghost commented Dec 1, 2017

Added rsync functionallity to transfer files from/to pods.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 1, 2017
@ghost
Copy link
Author

ghost commented Dec 4, 2017

[test]

@ghost
Copy link
Author

ghost commented Dec 4, 2017

@bparees Can you please review my PR?
I also added the rsh command from #81
to the help page.

@bparees
Copy link
Contributor

bparees commented Dec 4, 2017

@coreydaley please take a first pass. @gabemontero i'm ok w/ this if you are.

@gabemontero
Copy link
Contributor

I'm cool with it.

Opened #93 to track adding use of rsync to our automated test suite once we cut new versions of the plugin/image.

@gabemontero
Copy link
Contributor

I'll give @coreydaley a chance to chime in though before merging.

@coreydaley
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2017
@gabemontero
Copy link
Contributor

[merge]

@openshift-bot
Copy link

Evaluated for jenkins client plugin merge up to 1e3956d

@openshift-bot
Copy link

openshift-bot commented Dec 4, 2017

continuous-integration/openshift-jenkins-client-plugin/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_jenkins_client_plugin/8/) (Base Commit: 881f47c) (PR Branch Commit: 1e3956d) (Image: devenv-rhel7_9)

@openshift-bot
Copy link

Jenkins Client Plugin Action Required: Please contact #openshift-dev to have this pull request manually reviewed and tested

@openshift-bot openshift-bot merged commit 5b7cdb5 into openshift:master Dec 4, 2017
gabemontero pushed a commit to jenkinsci/openshift-client-plugin that referenced this pull request Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants