Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jkhelil as approver and reviewer #1035

Merged
merged 1 commit into from Mar 18, 2020
Merged

Add jkhelil as approver and reviewer #1035

merged 1 commit into from Mar 18, 2020

Conversation

akram
Copy link
Contributor

@akram akram commented Mar 13, 2020

/assign @waveywaves

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 13, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Mar 13, 2020
@akram
Copy link
Contributor Author

akram commented Mar 13, 2020

/test e2e-aws-jenkins

@jkhelil
Copy link
Contributor

jkhelil commented Mar 17, 2020

/verify-owners

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Mar 17, 2020
@jkhelil
Copy link
Contributor

jkhelil commented Mar 17, 2020

ci/prow/e2e-aws-jenkins

@jkhelil
Copy link
Contributor

jkhelil commented Mar 17, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akram, jkhelil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 71053a2 into openshift:master Mar 18, 2020
@jkhelil
Copy link
Contributor

jkhelil commented Mar 18, 2020 •
edited

/ci/prow/e2e-aws-jenkins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaviof otaviof Awaiting requested review from otaviof

@waveywaves waveywaves Awaiting requested review from waveywaves

Assignees

@jkhelil jkhelil

@waveywaves waveywaves

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@akram @jkhelil @openshift-ci-robot @openshift-bot @waveywaves @openshift-merge-robot