Bug 1848284: Support Nodejs 12 Agent #1043
Conversation
waveywaves
commented
Apr 2, 2020
waveywaves
commented
- Add Support for Nodejs 12 Agent for Jenkins
openshift-ci-robot
added
the
approved
|
/assign jawed |
|
@waveywaves: GitHub didn't allow me to assign the following users: jawed. Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @jkhelil |
| @@ -0,0 +1,32 @@ | |||
| FROM quay.io/openshift/origin-jenkins-agent-base:v4.0 | |||
|
|
|||
| MAINTAINER Akram Ben Aissi <abenaiss@redhat.com> | |||
There was a problem hiding this comment.
I would like to change all these by:
MAINTAINER OpenShift Developer Services openshift-dev-services+jenkins@redhat.com
can we start with with this one?
|
|
||
| imageName = os.Getenv("IMAGE_NAME") | ||
| if imageName == "" { | ||
| imageName = "vbobade/openshift-jenkins-base-agent" |
There was a problem hiding this comment.
it is only visible in the e2e test right?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akram, waveywaves The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
When will this image be available on Quay.io? |
|
/cherry-pick release-4.2 |
|
@waveywaves: new pull request created: #1074 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.3 |
|
/cherry-pick release-4.4 |
|
@waveywaves: new pull request created: #1075 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@waveywaves: new pull request created: #1076 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retitle Bug 1848284: Support Nodejs 12 Agent |
openshift-ci-robot
changed the title
|
@waveywaves: All pull requests linked via external trackers have merged: . Bugzilla bug 1848284 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
