Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated workflow-cps to version 2.92, compatible with kubernetes 1.29.7 #1293

Closed

Conversation

max-allan-surevine
Copy link

Fixes issue : #1292

@openshift-ci openshift-ci bot requested review from akram and sbose78 June 18, 2021 12:45
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2021

Hi @max-allan-surevine. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 18, 2021
@max-allan-surevine
Copy link
Author

/assign akram

@akram
Copy link
Contributor

akram commented Jun 18, 2021

#1294 should superseed your PR.

@akram
Copy link
Contributor

akram commented Jun 18, 2021

@openshift-ci openshift-ci bot closed this Jun 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2021

@akram: Closed this PR.

In response to this:

@max-allan-surevine I will close this PR in favor of #1294

If you think that we need 2.92 explicitely please comment on #1294

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_jenkins/1294/pull-ci-openshift-jenkins-master-images/1405880471593684992/artifacts/build-logs/jenkins.log

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akram
Copy link
Contributor

akram commented Jun 18, 2021

/reopen
/ok-to-test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2021

@akram: Reopened this PR.

In response to this:

/reopen
/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot reopened this Jun 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: max-allan-surevine
To complete the pull request process, please ask for approval from akram after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akram
Copy link
Contributor

akram commented Jun 18, 2021

There is an issue with the cron job that copies built images to quay.
/close

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2021

@akram: Closed this PR.

In response to this:

There is an issue with the cron job that copies built images to quay.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants