Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JKNS-346] Bump workflow_cps, kubernetes, kubernetes_client_api plugins #1659

Closed

Conversation

apoorvajagtap
Copy link
Contributor

Bumping the plugins to meet the requirements for openshift-sync-plugin v1.0.56.

@openshift-ci openshift-ci bot requested review from jkhelil and mbharatk April 9, 2023 16:02
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 9, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: apoorvajagtap
Once this PR has been reviewed and has the lgtm label, please assign divyansh42 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coreydaley
Copy link
Member

/retest
infra issues

@coreydaley
Copy link
Member

`com.google.inject.ProvisionException: Unable to provision, see the following errors:

  1. at GlobalPluginConfiguration.(GlobalPluginConfiguration.java:109)

Learn more:
https://github.com/google/guice/wiki/ERROR_INJECTING_CONSTRUCTOR

1 error`

This is an error that I was afraid we would run into eventually, it seems to be an incompatibility between the kubernetes client version, it changed at something like 5.10.something or 5.11 to be incompatible. Let's sync up about this later today and see if we can get it fixed up without having to rewrite anything major :)

@coreydaley
Copy link
Member

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2023

@apoorvajagtap: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-jenkins-sync-plugin aa5f221 link true /test e2e-aws-jenkins-sync-plugin
ci/prow/e2e-aws-jenkins-client-plugin aa5f221 link true /test e2e-aws-jenkins-client-plugin

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@saschalaudien
Copy link

@coreydaley We see the same issue when trying to upgrade the Kubernetes Plugin.
We are even forced to upgrade the kubernetes plugin to a much more current version(3910.ve59cec5e33ea_) then you are trying to integrate(1.31.2).
This is because of the latest Jenkins Security Advisory: https://www.jenkins.io/security/advisory/2023-04-12/

But I also made the test with the version(1.31.2) you are trying to integrate and receive the same error.

Would be great if you can find a solution for this so that we can upgrade the plugin and fix the issue from the Jenkins Security Advisory. Thanks.

@coreydaley
Copy link
Member

@coreydaley We see the same issue when trying to upgrade the Kubernetes Plugin. We are even forced to upgrade the kubernetes plugin to a much more current version(3910.ve59cec5e33ea_) then you are trying to integrate(1.31.2). This is because of the latest Jenkins Security Advisory: https://www.jenkins.io/security/advisory/2023-04-12/

But I also made the test with the version(1.31.2) you are trying to integrate and receive the same error.

Would be great if you can find a solution for this so that we can upgrade the plugin and fix the issue from the Jenkins Security Advisory. Thanks.
I have a series of pull requests open to the various openshift jenkins and openshift jenkins plugin repositories that i am hopeful will fix the issues, and i am working on testing them all together today.

@coreydaley
Copy link
Member

@saschalaudien I have no idea how I quoted your reply and posted it and didn't add my thoughts to it :( Long day I guess ...

We have pull requests open to each of our Jenkins OpenShift plugin repositories along with one to our main Jenkins image repository that we are testing that should take care of all of this nonsense, hoping to get them all tested and merged this week and then released as new images shortly after that.

@saschalaudien
Copy link

@coreydaley No worries. But I also asked myself about the meaning of your reply ;-)

Thanks for your answer. I wish you the best to get all of the stuff fixed and tested.
Would be great if you can post here the link to the fixed Jenkins image and the versions of the plugins we need to upgrade.

Have a nice day.

@coreydaley
Copy link
Member

/hold
until #1666 merges and then we will rebase and see if it is still needed

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2023
@coreydaley
Copy link
Member

/close
This has been taken care of by #1666

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this May 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2023

@coreydaley: Closed this PR.

In response to this:

/close
This has been taken care of by #1666

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschalaudien
Copy link

@coreydaley Any ideas when a Jenkins Openshift Image with this fix (#1666) will be available in the RedHat Catalog?

@coreydaley
Copy link
Member

No specific dates but we are working on it and hope to release it very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants