[release-4.1] Bug 1712240: login plugin account for the jenkins SA certificate diff… #856
Conversation
…ering from the oauth server's router certificate (where SSL handshake errors would then occur with jenkins SA certificate) by falling back to the JVM's default keystore
openshift-ci-robot
added
the
size/XS
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
gabemontero
added
approved
|
will unhold when 4.1 opens up |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
cloudbees plugin download hiccup during image builds ... will try again later |
|
/retest |
|
ok image built but installer rate limit looking problem on e2e-aws-jenkins |
|
/retest |
|
back to jenkins download center pain ... will try again this evening |
|
/retest |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
@openshift-merge-robot: This pull request references an invalid Bugzilla bug:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
gabemontero
changed the title
openshift-ci-robot
added
bugzilla/valid-bug
|
@openshift-cherrypick-robot: This pull request references a valid Bugzilla bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@bparees @derekwaynecarr this one impacted @jupierce 's use of jenkins in starter in conjunction with how they have set up certs (they have a "non-default" cert configuration) I believe he is currently using the 4.2 version of this fix currently available at quay.io in the interim Does this make the initial 4.1.z cut off ? |
|
It would be great to have this in the next patch release. Default for the Jenkins templates is to enable OAUTH. And this breaks OAUTH. |
|
On Fri, Jun 7, 2019 at 1:07 PM Wolfgang Kulhanek ***@***.***> wrote:
It would be great to have this in the next patch release. Default for the
Jenkins templates is to enable OAUTH. And this breaks OAUTH.
Breaks OAUTH if non-default certs are set up for the oauth server
A vanilla install does not see this
… —
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#856?email_source=notifications&email_token=AA3NU5CLZZDFL3MXFE7PC33PZKISRA5CNFSM4HOLQFAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXGNP2A#issuecomment-499963880>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA3NU5AQYVVUI2ROPK6UEGTPZKISRANCNFSM4HOLQFAA>
.
|
|
referenced pr was merged a month ago. |
derekwaynecarr
added
the
cherry-pick-approved
|
master branch PR #854 merged May 17 |
|
Opened https://jira.coreos.com/browse/ART-681 to get jenkins plugin rpm updated ... combination of 4 recent plugin updates for 4.1 |
|
plugin list #860 (comment) |
This is an automated cherry-pick of #854
/assign gabemontero