Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1907390: bump to k8s 1.20 #41

Merged
merged 8 commits into from Dec 15, 2020
Merged

Bug 1907390: bump to k8s 1.20 #41

merged 8 commits into from Dec 15, 2020

Conversation

s-urbaniak
Copy link

dgrisonnet and others added 8 commits December 2, 2020 18:28
@dgrisonnet
go.mod: bump metrics-server
6d8a82f 
Include a fix to the NodeMetrics and PodMetrics APIs to match k8s
conventions.
- NodeMetrics and PodMetrics now have labels as they can be filtered by
them
- Field selector is now applied to NodeMetrics and PodMetrics instead
of Nodes and Pods

Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
@s-urbaniak
Merge pull request kubernetes-sigs#344 from dgrisonnet/bump-metrics-s…
be35274 
…erver

Make NodeMetrics and PodMetrics APIs match K8s conventions
@s-urbaniak
go.mod: bump to k8s 1.20
269295a
@s-urbaniak
vendor: revendor
9f0440b
@s-urbaniak
pkg/api/generated: regenerate
147b5c8
@s-urbaniak
Makefile: bump to Go 1.15
96cdc4d
@s-urbaniak
Merge pull request kubernetes-sigs#352 from s-urbaniak/bump-1.20
aa77eca 
bump to k8s 1.20, go 1.15
@s-urbaniak
Merge remote-tracking branch 'origin/master' into bz-1907390
207d624
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 14, 2020
@openshift-ci-robot
Copy link

@s-urbaniak: This pull request references Bugzilla bug 1907390, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1907390: bump to k8s 1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak
Copy link
Author

/cc @openshift/openshift-team-monitoring

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2020
@openshift-ci-robot openshift-ci-robot requested a review from a team December 14, 2020 12:30
@dgrisonnet
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dgrisonnet,s-urbaniak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dgrisonnet
Copy link
Member

/retest

1 similar comment
@dgrisonnet
Copy link
Member

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@s-urbaniak
Copy link
Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 3922432 into openshift:master Dec 15, 2020
@openshift-ci-robot
Copy link

@s-urbaniak: All pull requests linked via external trackers have merged:

Bugzilla bug 1907390 has been moved to the MODIFIED state.

In response to this:

Bug 1907390: bump to k8s 1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak s-urbaniak deleted the bz-1907390 branch December 15, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

Assignees

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@s-urbaniak @openshift-ci-robot @dgrisonnet @openshift-bot @openshift-merge-robot