Bug 2002281: 4.8: pkg/resourceprovider: guard from negative metrics #55
Conversation
When serving the resource metrics API, prometheus-adapter may return negative values for pods/nodes memory and CPU usage. This happens because Prometheus sees counter resets which results in Prometheus interpolating data incorrectly to avoid the counter value going down. To prevent that, we need to add some guards in prometheus-adapter to replace the negative value by zero whenever it detects one. Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
openshift-ci
bot
added
the
bugzilla/severity-medium
|
@dgrisonnet: This pull request references Bugzilla bug 2002281, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
openshift-ci
bot
added
the
approved
|
/assign @simonpasquier |
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
|
/lgtm |
|
/bugzilla cc-qa |
|
@juzhao: An error was encountered querying GitHub for users with public email (juzhao@redhat.com) for bug 2002281 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
tested with the fix, watched for a while, did not see negative value for |
|
/lgtm |
openshift-ci
bot
added
the
qe-approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, juzhao, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mfojtik
added
the
cherry-pick-approved
|
[patch-manager] 🚀 Approved for z-stream by score: 0.20 adding cherry-pick approved |
|
@dgrisonnet: All pull requests linked via external trackers have merged: Bugzilla bug 2002281 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-prometheus-adapter-container-v4.8.0-202311261141.p0.gbfffea3.assembly.stream for distgit ose-prometheus-adapter. |
Cherry-pick of 0b3ac78 on release-4.8.