Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2002281: 4.8: pkg/resourceprovider: guard from negative metrics #55

Merged
merged 2 commits into from Sep 10, 2021
Merged

Bug 2002281: 4.8: pkg/resourceprovider: guard from negative metrics #55

merged 2 commits into from Sep 10, 2021

Commits on Sep 8, 2021

  1. pkg/resourceprovider: guard from negative metrics 

    When serving the resource metrics API, prometheus-adapter may return
negative values for pods/nodes memory and CPU usage. This happens
because Prometheus sees counter resets which results in Prometheus
interpolating data incorrectly to avoid the counter value going down.
To prevent that, we need to add some guards in prometheus-adapter to
replace the negative value by zero whenever it detects one.

Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
    @dgrisonnet
    dgrisonnet committed Sep 8, 2021
    Copy the full SHA
    2e5f24d View commit details
    Browse the repository at this point in the history

  2. pkg: make resource provider compatible with v0.8.4 

    Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
    @dgrisonnet
    dgrisonnet committed Sep 8, 2021
    Copy the full SHA
    21e8734 View commit details
    Browse the repository at this point in the history