OCPBUGS-30145: fix: Prevented memory leak generated by not correctly cleaned HTTP resources (#5293) #26
Conversation
openshift-ci-robot
added
jira/severity-moderate
|
@jkyros: This pull request references Jira Issue OCPBUGS-30145, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@jkyros: This pull request references Jira Issue OCPBUGS-30145, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (schoudha@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
@jkyros: This pull request references Jira Issue OCPBUGS-30145, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (schoudha@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
… cleaned HTTP resources (kedacore#5293) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> This wasn't a completely clean pick, I had to adjust the swift scaler client variable to be a pointer so it was nillable, but everything else was okay.
jkyros
force-pushed
the
http-fix-memory-leak
branch
from
aff89e7
to
cd2197d
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkyros, joelsmith The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/keda-e2e-aws-ovn |
|
@joelsmith: Overrode contexts on behalf of joelsmith: ci/prow/keda-e2e-aws-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jkyros: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@jkyros: Jira Issue OCPBUGS-30145: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-30145 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
We had a memory leak situation where scalers with improper fields in the metadata (e.g. namespaces that did not exist) were causing memory to leak because http clients weren't getting cleaned up.
It just so happens that Joel noticed this was fixed upstream already in 2.13 (thanks Joel!), so this cherry-picks it back from 2.13 to 2.12.
With this fix, memory usage seems to plateau at 72Meg (for me, with 1 scaledObject) and no longer leaks.
NOTE: It wasn't a completely clean pick, I had to mess with the openstack swift scaler, they changed clients between 2.12 and 2.13 so the code didn't line up, but I don't think I broke anything.
Fixes # OCPBUGS-30145