Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Add all RHEL architectures #411

Closed
wants to merge 2 commits into from
Closed

Add all RHEL architectures #411

wants to merge 2 commits into from

Conversation

yselkowitz
Copy link

The "build and release" commit is relevant to upstream, the "package and serve" commit should be midstream-specific. Let me know if I need to handle the former differently.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yselkowitz
To complete the pull request process, please assign rhuss
You can assign the PR to them by writing /assign @rhuss in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

Hi @yselkowitz. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 30, 2020
@navidshaikh
Copy link

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 1, 2020
Copy link

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for putting this together!

The changes in first commit 'Build and release' should ideally go upstream, files changed in that commit (hack/build.sh, hack/release.sh) are synced from upstream,
and its better done upstream than carry any patch for them.

re: PR against release-v0.14.0 branch

client release v0.14.0 is going with Serverless Operator 1.8.0-rc1 release, which is past its code-freeze and on QA now.

These changes would require additional changes

  • in the Operator where it shows the ConsoleCLIDownload in console downloads page, where we'd enlist these additional architecture.
  • in the kn-cli-artifacts image Dockerfile which carries the cross platform binaries for serving them within cluster
  • in the mirror.openshift.com sync script

(the above changes can be handled by client team, we should target additional archs for client v0.15.0)

Can you please PR the changes in first commit against upstream master at knative/client ?

Meanwhile, this PR can be opened against release-next and master branch of openshift/knative-client.

/hold

@navidshaikh navidshaikh added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2020
@navidshaikh
Copy link

navidshaikh commented Jul 1, 2020

The changes in first commit 'Build and release' should ideally go upstream, files changed in that commit (hack/build.sh, hack/release.sh) are synced from upstream,
and its better done upstream than carry any patch for them.

@yselkowitz : @rhuss suggests to hold on raising the additional arch build/release PR upstream, as we'd to support/troubleshoot them in case of issues which is more feasible downstream than upstream.

@yselkowitz
Copy link
Author

I have filed PRs for master and release-next here, along with in the operator to add the links. The kn-cli-artifacts Dockerfile does require a change as you mention, but it appears that needs to be coordinated downstream. Where is the mirror.openshift.com sync script hosted?

@navidshaikh
Copy link

Where is the mirror.openshift.com sync script hosted?

https://github.com/openshift/aos-cd-jobs/blob/master/build-scripts/rcm-guest/publish-kn-binary.sh

The input URL for this script to download the binaries are given by RCM after signing binaries for macOS and Windows. RCM extracts the -redistributable RPM and sign the mentioned platform binaries and copy over other binaries at export location.
The sync script in its current form will be used by ART team for syncing the binaries for release which is on QA now.
We'll first need to co-ordinate with RCM about export location structure and notify about the change coming, I will copy you on the ticket.

@yselkowitz
Copy link
Author

Since this won't make 0.14.0, closing this PR in favour of the others since flied.

@yselkowitz yselkowitz closed this Jul 3, 2020
@yselkowitz yselkowitz deleted the release-v0.14.0 branch July 8, 2022 02:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
3 participants