Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yselkowitz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @yselkowitz. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for putting this together!
The changes in first commit 'Build and release' should ideally go upstream, files changed in that commit (hack/build.sh, hack/release.sh
) are synced from upstream,
and its better done upstream than carry any patch for them.
re: PR against release-v0.14.0 branch
client release v0.14.0 is going with Serverless Operator 1.8.0-rc1 release, which is past its code-freeze and on QA now.
These changes would require additional changes
- in the Operator where it shows the ConsoleCLIDownload in console downloads page, where we'd enlist these additional architecture.
- in the kn-cli-artifacts image Dockerfile which carries the cross platform binaries for serving them within cluster
- in the mirror.openshift.com sync script
(the above changes can be handled by client team, we should target additional archs for client v0.15.0)
Can you please PR the changes in first commit against upstream master at knative/client ?
Meanwhile, this PR can be opened against release-next and master branch of openshift/knative-client.
/hold
@yselkowitz : @rhuss suggests to hold on raising the additional arch build/release PR upstream, as we'd to support/troubleshoot them in case of issues which is more feasible downstream than upstream. |
I have filed PRs for master and release-next here, along with in the operator to add the links. The kn-cli-artifacts Dockerfile does require a change as you mention, but it appears that needs to be coordinated downstream. Where is the mirror.openshift.com sync script hosted? |
https://github.com/openshift/aos-cd-jobs/blob/master/build-scripts/rcm-guest/publish-kn-binary.sh The input URL for this script to download the binaries are given by RCM after signing binaries for macOS and Windows. RCM extracts the |
Since this won't make 0.14.0, closing this PR in favour of the others since flied. |
The "build and release" commit is relevant to upstream, the "package and serve" commit should be midstream-specific. Let me know if I need to handle the former differently.