UPSTREAM: <carry>: openshift: Move MaxNodesTotalReached event #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emit MaxNodesTotalReached in scale up when the condition is reached.
openshift-ci-robot
added
the
size/XS
frobware
force-pushed
the
move-maxnodes-total-event
branch
from
fd90a4c
to
c2f1516
Compare
|
/refresh |
|
/retest |
| @@ -295,9 +295,7 @@ func (a *StaticAutoscaler) RunOnce(currentTime time.Time) errors.AutoscalerError | |||
| klog.V(1).Info("No unschedulable pods") | |||
| } else if a.MaxNodesTotal > 0 && len(readyNodes) >= a.MaxNodesTotal { | |||
| scaleUpStatus.Result = status.ScaleUpNoOptionsAvailable | |||
There was a problem hiding this comment.
Let the Result also be filled by ScaleUp() and totally omit this else if. WDYT?
There was a problem hiding this comment.
I don't really want to change existing behaviour. All I want is the event emitted when the cluster can scale up no more. I'm hoping that's the smaller, simplest and most discrete change particularly as we want to carry our change from rebase to rebase.
There was a problem hiding this comment.
I am fine if you want to take care of event part only. Though i think it wont change behavior if we move the filling up Result to the ScaleUp, leave it to you to decide whether to include in this PR or not.
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the location of where the event is emitted from by reverting PR #90 and emitting the event during scale-up.