Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1872080: Updating vertical-pod-autoscaler/Dockerfile.rhel7 baseimages to mach ocp-build-data config #167

Conversation

openshift-bot
Copy link

This PR is autogenerated by the ocp-build-data-enforcer.
It updates the baseimages in the Dockerfile used for promotion in order to ensure it
matches the configuration in the ocp-build-data repository used
for producing release artifacts.

If you believe the content of this PR is incorrect, please contact the dptp team in
#forum-testplatform.

…ocp-build-data config

This PR is autogenerated by the [ocp-build-data-enforcer][1].
It updates the baseimages in the Dockerfile used for promotion in order to ensure it
matches the configuration in the [ocp-build-data repository][2] used
for producing release artifacts.

If you believe the content of this PR is incorrect, please contact the dptp team in
#forum-testplatform.

[1]: https://github.com/openshift/ci-tools/tree/master/cmd/ocp-build-data-enforcer
[2]: https://github.com/openshift/ocp-build-data/tree/openshift-4.6-rhel-8/images
@jupierce jupierce changed the title Updating vertical-pod-autoscaler/Dockerfile.rhel7 baseimages to mach ocp-build-data config Bug 1872080: Updating vertical-pod-autoscaler/Dockerfile.rhel7 baseimages to mach ocp-build-data config Aug 25, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 25, 2020
@openshift-ci-robot
Copy link

@openshift-bot: This pull request references Bugzilla bug 1872080, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1872080: Updating vertical-pod-autoscaler/Dockerfile.rhel7 baseimages to mach ocp-build-data config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 25, 2020
@JoelSpeed
Copy link

/approve
/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2020
@Danil-Grigorev
Copy link

Is it possible to fix git-history? @JoelSpeed @jupierce

UPSTREAM: <carry>: message  (commits that should be carried indefinitely)
UPSTREAM: <drop>: message   (commits that should be dropped on the next upstream rebase)
UPSTREAM: 1234: message     (commits that should be carried until an upstream rebase includes upstream PR 1234)

@JoelSpeed
Copy link

We can open another PR to fix the history, but it's not necessary.

In this case, I think it might be preferable though. We rebase this repo often so it would be useful to know that this needs to be carried. Let's hold this and create a replacement for it.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2020
@elmiko
Copy link

elmiko commented Aug 25, 2020

i've added #169 to replace this pr.
/hold

@jupierce
Copy link

jupierce commented Sep 1, 2020

/retest

1 similar comment
@jupierce
Copy link

jupierce commented Sep 2, 2020

/retest

@openshift-ci-robot
Copy link

@openshift-bot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/git-history bd64976 link /test git-history

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jupierce
Copy link

jupierce commented Sep 2, 2020

Replaced by #169

@jupierce jupierce closed this Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants