New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG 1872080: Add vertical-pod-autoscaler/Dockerfile.rhel to match build configuration in ocp-build-data #169
Conversation
@elmiko: This pull request references Bugzilla bug 1872080, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
this is being created to replace #167 |
…rhel to match build configuration in ocp-build-data This change adds a new Dockerfile.rhel file to control building release images. It updates the baseimages in the Dockerfile used for promotion in order to ensure it matches the configuration in the [ocp-build-data repository](https://github.com/openshift/ocp-build-data/tree/openshift-4.6-rhel-8/images) used for producing release artifacts. After this change merges, the release files in https://github.com/openshift/release/blob/master/ci-operator/config/openshift/kubernetes-autoscaler/openshift-kubernetes-autoscaler-master.yaml should be updated with the new dockerfile path.
@elmiko: This pull request references Bugzilla bug 1872080, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@elmiko: This pull request references Bugzilla bug 1872080, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
1 similar comment
/retest |
ping @joelsmith |
Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelsmith The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@elmiko: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
This change is in support of bugzilla 1872080. It modifies the configuration files for the machine-api components by adjusting their dockerfile to match the newly created "Dockerfile.rhel" files. This change also depends on several pull requests and should not be merged until they are: openshift/machine-api-operator#692 openshift/cluster-api-provider-gcp#118 openshift/cluster-api-provider-aws#349 openshift/cluster-api-provider-ovirt#67 openshift/cluster-api-provider-openstack#115 openshift/kubernetes-autoscaler#169 openshift/kubernetes-autoscaler#168 openshift/cluster-api-provider-azure#161 openshift/cluster-api-provider-baremetal#102 openshift/cluster-autoscaler-operator#161 openshift/cluster-machine-approver#83
adding a reference to the dependent PR, openshift-eng/ocp-build-data#636 |
This change is in support of bugzilla 1872080. It modifies the configuration files for the machine-api components by adjusting their dockerfile to match the newly created "Dockerfile.rhel" files. This change also depends on several pull requests and should not be merged until they are: openshift/machine-api-operator#692 openshift/cluster-api-provider-gcp#118 openshift/cluster-api-provider-aws#349 openshift/cluster-api-provider-ovirt#67 openshift/cluster-api-provider-openstack#115 openshift/kubernetes-autoscaler#169 openshift/kubernetes-autoscaler#168 openshift/cluster-api-provider-azure#161 openshift/cluster-api-provider-baremetal#102 openshift/cluster-autoscaler-operator#161 openshift/cluster-machine-approver#83
This change adds a new Dockerfile.rhel file to control building release
images. It updates the baseimages in the Dockerfile used for promotion
in order to ensure it matches the configuration in the
ocp-build-data
repository
used for producing release artifacts.
After this change merges, the release files in
https://github.com/openshift/release/blob/master/ci-operator/config/openshift/kubernetes-autoscaler/openshift-kubernetes-autoscaler-master.yaml
and
https://github.com/openshift/ocp-build-data/blob/openshift-4.6/images/vertical-pod-autoscaler.yml
should be updated with the new dockerfile path.