New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2022259: Rebase v1.20.12 #1046
Bug 2022259: Rebase v1.20.12 #1046
Conversation
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Removing myself for now as I navigate the transition to the Prow team.
Due to a cut-and-paste error in the original implementation in Kubernetes 1.19, support for generic ephemeral inline volumes in the PVC protection controller was incorrectly tied to the "storage object in use" feature gate.
Instead of a plain `Mutex`, use an `RWMutex` so that the common operations can proceed in parallel.
…ick-of-#104833-upstream-release-1.20 Automated cherry pick of kubernetes#104833 (1.20): Refine locking in API Priority and Fairness config controller
…k-of-#100125-upstream-release-1.20 Automated cherry pick of kubernetes#100125: 'New' Event namespace validate failed
Some tests are checking the network connectivity using gomega.Consistently, which will fail if any of the checks fails. This could lead to flakyness in some scenarios in which kube-proxy was supposed to apply Policies for Kubernetes services. We can instead wait for the network connectivity to work first using gomega.Eventually, after which we can check the consistency.
…ck-of-#104969-upstream-release-1.20 Automated cherry pick of kubernetes#104969: Propagate conversion errors
Otherwise, nodeNameToPodList[nodeName] list will have all its references identical (corresponding to the control variable reference). Thus, making all the pods in the list identical.
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
Revert 102925: Fix Node Resources plugins score when there are pods with no requests
/test e2e-metal-ipi |
1 similar comment
/test e2e-metal-ipi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/label backport-risk-assessed
/label backports/validated-commits
/remove-label backports/unvalidated-commits
/override ci/prow/verify-commits
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh, tjungblu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify-commits In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 2022259, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 2022259, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 2022259, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label cherry-pick-approved |
#1060 merged so manually setting valid-bug label |
/override ci/prow/verify-commits |
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify-commits In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-aws-serial |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@tjungblu: All pull requests linked via external trackers have merged: Bugzilla bug 2022259 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This fix contains the following changes coming from updated version of kubernetes from 1.20.11 up to v1.20.12:
Changelog for v1.20.12:
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.20.md#changelog-since-v12011