Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2022259: Rebase v1.20.12 #1046

Merged
merged 47 commits into from Nov 19, 2021

Conversation

tjungblu
Copy link

This fix contains the following changes coming from updated version of kubernetes from 1.20.11 up to v1.20.12:

Changelog for v1.20.12:
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.20.md#changelog-since-v12011

dims and others added 30 commits June 8, 2021 17:30
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Removing myself for now as I navigate the transition to the Prow team.
Due to a cut-and-paste error in the original implementation in Kubernetes 1.19,
support for generic ephemeral inline volumes in the PVC protection controller
was incorrectly tied to the "storage object in use" feature gate.
Instead of a plain `Mutex`, use an `RWMutex` so that the common
operations can proceed in parallel.
…ick-of-#104833-upstream-release-1.20

Automated cherry pick of kubernetes#104833 (1.20): Refine locking in API Priority and Fairness config controller
…k-of-#100125-upstream-release-1.20

Automated cherry pick of kubernetes#100125: 'New' Event namespace validate failed
Some tests are checking the network connectivity using gomega.Consistently,
which will fail if any of the checks fails. This could lead to flakyness in
some scenarios in which kube-proxy was supposed to apply Policies for
Kubernetes services.

We can instead wait for the network connectivity to work first using gomega.Eventually,
after which we can check the consistency.
…ck-of-#104969-upstream-release-1.20

Automated cherry pick of kubernetes#104969: Propagate conversion errors
Otherwise, nodeNameToPodList[nodeName] list will have all its references
identical (corresponding to the control variable reference).
Thus, making all the pods in the list identical.
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
Revert 102925: Fix Node Resources plugins score when there are pods with no requests
@tjungblu
Copy link
Author

/test e2e-metal-ipi

1 similar comment
@tjungblu
Copy link
Author

/test e2e-metal-ipi

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/label backport-risk-assessed
/label backports/validated-commits
/remove-label backports/unvalidated-commits
/override ci/prow/verify-commits

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Nov 16, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 16, 2021

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify-commits

In response to this:

/lgtm
/approve
/label backport-risk-assessed
/label backports/validated-commits
/remove-label backports/unvalidated-commits
/override ci/prow/verify-commits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link

openshift-ci bot commented Nov 17, 2021

@openshift-bot: This pull request references Bugzilla bug 2022259, which is invalid:

  • expected the bug to target the "4.7.z" release, but it targets "---" instead
  • expected dependent Bugzilla bug 2022265 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
  • expected dependent Bugzilla bug 2022265 to target a release in 4.8.0, 4.8.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2021

@openshift-bot: This pull request references Bugzilla bug 2022259, which is invalid:

  • expected the bug to target the "4.7.z" release, but it targets "---" instead
  • expected dependent Bugzilla bug 2022265 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
  • expected dependent Bugzilla bug 2022265 to target a release in 4.8.0, 4.8.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2021

@openshift-bot: This pull request references Bugzilla bug 2022259, which is invalid:

  • expected the bug to target the "4.7.z" release, but it targets "---" instead
  • expected dependent Bugzilla bug 2022265 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
  • expected dependent Bugzilla bug 2022265 to target a release in 4.8.0, 4.8.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wangke19
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 19, 2021
@soltysh
Copy link
Member

soltysh commented Nov 19, 2021

#1060 merged so manually setting valid-bug label
/label bugzilla/valid-bug
/remove-label bugzilla/invalid-bug

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 19, 2021
@soltysh
Copy link
Member

soltysh commented Nov 19, 2021

/override ci/prow/verify-commits

@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2021

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify-commits

In response to this:

/override ci/prow/verify-commits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu
Copy link
Author

/test e2e-aws-serial

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit aa025a0 into openshift:release-4.7 Nov 19, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2021

@tjungblu: All pull requests linked via external trackers have merged:

Bugzilla bug 2022259 has been moved to the MODIFIED state.

In response to this:

Bug 2022259: Rebase v1.20.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet