Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base branch oc-4.4-kubernetes-1.17.0 #105

Conversation

sallyom
Copy link

@sallyom sallyom commented Dec 11, 2019

/assign @soltysh

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes labels Dec 11, 2019
@sallyom sallyom force-pushed the oc-4.4-kubernetes-1.17.0-bump branch from f73bc5e to 2efa643 Compare December 12, 2019 15:55
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 12, 2019
@sallyom sallyom force-pushed the oc-4.4-kubernetes-1.17.0-bump branch from 2efa643 to 9eb77b3 Compare December 12, 2019 17:46
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 12, 2019
@sallyom sallyom force-pushed the oc-4.4-kubernetes-1.17.0-bump branch 2 times, most recently from 0b33d10 to 74beaf6 Compare December 15, 2019 15:15
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 15, 2019
@sallyom
Copy link
Author

sallyom commented Dec 15, 2019

/retest

1 similar comment
@sallyom
Copy link
Author

sallyom commented Dec 16, 2019

/retest

-o -path './staging/src/k8s.io/apiserver/pkg/server/options/*' \
-o -path './staging/src/k8s.io/apiserver/pkg/util/webhook/*' \
-o -path './staging/src/k8s.io/apiserver/plugin/pkg/authorizer/webhook/*' \
-o -path './staging/src/k8s.io/legacy-cloud-providers/gce/*' \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add -o -path './staging/src/k8s.io/csi-translation-lib/*' \ we don't care about that either.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok done

@sallyom sallyom force-pushed the oc-4.4-kubernetes-1.17.0-bump branch from 74beaf6 to 7aac7c5 Compare December 16, 2019 14:12
@sallyom sallyom force-pushed the oc-4.4-kubernetes-1.17.0-bump branch from 7aac7c5 to 39110b9 Compare December 16, 2019 14:15
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2019
@soltysh soltysh added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2019
@soltysh soltysh merged commit 079984b into openshift:oc-4.4-kubernetes-1.17.0 Dec 16, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: sallyom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants