Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1986504: UPSTREAM 107682: Fix printing control character in kubectl explain #1137

Conversation

slaskawi
Copy link

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jan 24, 2022
@openshift-ci-robot
Copy link

@slaskawi: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@slaskawi slaskawi changed the title Bug1986504: UPSTREAM: <drop>: Fix printing control character in kubectl explain Fix printing control character in kubectl explain Jan 24, 2022
@slaskawi
Copy link
Author

/validate-backports

@openshift-ci-robot
Copy link

@slaskawi: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci
Copy link

openshift-ci bot commented Jan 24, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: slaskawi
To complete the pull request process, please assign deads2k after the PR has been reviewed.
You can assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from soltysh and sttts January 24, 2022 07:37
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Jan 24, 2022
@slaskawi slaskawi changed the title Fix printing control character in kubectl explain Bug1986504: UPSTREAM 107682: Fix printing control character in kubectl explain Jan 24, 2022
@slaskawi
Copy link
Author

/validate-backports

@openshift-ci-robot
Copy link

@slaskawi: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@s-urbaniak
Copy link

/retitle Bug 1986504: UPSTREAM 107682: Fix printing control character in kubectl explain

@openshift-ci openshift-ci bot changed the title Bug1986504: UPSTREAM 107682: Fix printing control character in kubectl explain Bug 1986504: UPSTREAM 107682: Fix printing control character in kubectl explain Jan 24, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 24, 2022

@slaskawi: This pull request references Bugzilla bug 1986504, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ytripath@redhat.com), skipping review request.

In response to this:

Bug 1986504: UPSTREAM 107682: Fix printing control character in kubectl explain

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@slaskawi slaskawi force-pushed the opwnshift_fix_kubectl_explain_description_printer branch from b12ffdf to 88843ef Compare January 24, 2022 07:44
@openshift-ci-robot
Copy link

@slaskawi: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@slaskawi
Copy link
Author

/validate-backports

@openshift-ci-robot
Copy link

@slaskawi: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci
Copy link

openshift-ci bot commented Jan 24, 2022

@slaskawi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-commits 88843ef link true /test verify-commits
ci/prow/e2e-aws-csi 88843ef link false /test e2e-aws-csi
ci/prow/e2e-aws-crun 88843ef link false /test e2e-aws-crun

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@slaskawi
Copy link
Author

Closed in favor of openshift/kubernetes-kubectl#45

@slaskawi slaskawi closed this Jan 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 24, 2022

@slaskawi: This pull request references Bugzilla bug 1986504. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 1986504: UPSTREAM 107682: Fix printing control character in kubectl explain

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants