Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6][ART-3664] Bug 2043805: IPs with leading zeros are still valid in the apiserver #1235

Merged
merged 2 commits into from May 18, 2022
Merged

[release-4.6][ART-3664] Bug 2043805: IPs with leading zeros are still valid in the apiserver #1235

merged 2 commits into from May 18, 2022

Conversation

locriandev
Copy link

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Apr 7, 2022
@openshift-ci-robot
Copy link

@locriandev: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 7, 2022

@locriandev: This pull request references Bugzilla bug 2043805, which is invalid:

  • expected dependent Bugzilla bug 2043804 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6][ART-3664] Bug 2043805: IPs with leading zeros are still valid in the apiserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from deads2k and mfojtik April 7, 2022 20:56
@locriandev locriandev force-pushed the 20220405-art3664-golang-update branch from 32e7fa0 to b6c0e69 Compare April 12, 2022 17:03
@openshift-ci-robot
Copy link

@locriandev: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@locriandev locriandev force-pushed the 20220405-art3664-golang-update branch from b6c0e69 to 4ad5cc0 Compare May 2, 2022 15:05
@openshift-ci-robot
Copy link

@locriandev: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@locriandev
Copy link
Author

/assign aojea

@aojea
Copy link

aojea commented May 10, 2022

/lgtm
/retest required

@openshift-ci
Copy link

openshift-ci bot commented May 10, 2022

@aojea: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test configmap-scale
  • /test e2e-agnostic-upgrade
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-jenkins
  • /test e2e-aws-ovn
  • /test e2e-aws-serial
  • /test e2e-azure
  • /test e2e-gcp
  • /test images
  • /test integration
  • /test k8s-e2e-conformance-aws
  • /test k8s-e2e-gcp
  • /test k8s-e2e-gcp-serial
  • /test unit
  • /test verify
  • /test verify-commits

The following commands are available to trigger optional jobs:

  • /test e2e-agnostic-cmd
  • /test e2e-aws-disruptive
  • /test e2e-vsphere

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-kubernetes-release-4.6-e2e-agnostic-cmd
  • pull-ci-openshift-kubernetes-release-4.6-e2e-agnostic-upgrade
  • pull-ci-openshift-kubernetes-release-4.6-e2e-aws
  • pull-ci-openshift-kubernetes-release-4.6-e2e-aws-csi
  • pull-ci-openshift-kubernetes-release-4.6-e2e-aws-jenkins
  • pull-ci-openshift-kubernetes-release-4.6-e2e-aws-ovn
  • pull-ci-openshift-kubernetes-release-4.6-e2e-aws-serial
  • pull-ci-openshift-kubernetes-release-4.6-e2e-azure
  • pull-ci-openshift-kubernetes-release-4.6-e2e-gcp
  • pull-ci-openshift-kubernetes-release-4.6-images
  • pull-ci-openshift-kubernetes-release-4.6-integration
  • pull-ci-openshift-kubernetes-release-4.6-k8s-e2e-conformance-aws
  • pull-ci-openshift-kubernetes-release-4.6-k8s-e2e-gcp
  • pull-ci-openshift-kubernetes-release-4.6-k8s-e2e-gcp-serial
  • pull-ci-openshift-kubernetes-release-4.6-unit
  • pull-ci-openshift-kubernetes-release-4.6-verify
  • pull-ci-openshift-kubernetes-release-4.6-verify-commits

In response to this:

/lgtm
/retest required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2022
@locriandev
Copy link
Author

/test k8s-e2e-gcp

@openshift-bot
Copy link

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 11, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 11, 2022

@openshift-bot: This pull request references Bugzilla bug 2043805, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2043804 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2043804 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @wangke19

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from wangke19 May 11, 2022 01:01
@locriandev
Copy link
Author

/test k8s-e2e-gcp

@openshift-ci
Copy link

openshift-ci bot commented May 17, 2022

@locriandev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@locriandev
Copy link
Author

/validate-backports

@openshift-ci-robot
Copy link

@locriandev: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

soltysh
soltysh approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/label backport-risk-assessed
/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 18, 2022
@openshift-ci openshift-ci bot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label May 18, 2022
@openshift-ci openshift-ci bot removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 18, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, locriandev, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2022
@gangwgr
Copy link

gangwgr commented May 18, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 18, 2022
@openshift-merge-robot openshift-merge-robot merged commit 8203b20 into openshift:release-4.6 May 18, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 18, 2022

@locriandev: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2043805 has not been moved to the MODIFIED state.

In response to this:

[release-4.6][ART-3664] Bug 2043805: IPs with leading zeros are still valid in the apiserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@locriandev locriandev deleted the 20220405-art3664-golang-update branch May 18, 2022 09:29
@openshift-ci openshift-ci bot mentioned this pull request May 18, 2022
Merged
@openshift-ci openshift-ci bot mentioned this pull request May 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees

@soltysh soltysh

@aojea aojea

@kasturinarra kasturinarra

@zhouying7780 zhouying7780

@xingxingxia xingxingxia

@sunilcio sunilcio

@duanwei33 duanwei33

@wangke19 wangke19

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet