UPSTREAM: 113799: tests: network: Prefer internal IPs first #1446
Conversation
openshift-ci-robot
added
the
backports/unvalidated-commits
|
/kind bug |
|
@jluhrsen: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
jluhrsen
force-pushed
the
OCPBUGS-1661
branch
from
6799559
to
50ffaa1
Compare
|
@jluhrsen: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/retest |
1 similar comment
|
/retest |
jluhrsen
changed the title
|
@deads2k, when you have a chance can you take a look at this one please? |
|
/retest |
|
/validate-backports |
|
@jluhrsen: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
Many clusters block direct requests from internal resources to the nodes external IPs as best practice. All accesses from internal resources that want to access resources running on nodes go through load balancers, nodes being on private or public subnets. Let's prefer internal IPs first, so the tests can work even when there are security group rules present blocking requests to the external IPs. We should not require ExternalIP for Conformance, but should keep testing ExternalIPs in sig network. Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
openshift-ci-robot
added
the
backports/validated-commits
|
@jluhrsen: the contents of this pull request could be automatically validated. The following commits are valid:
Comment |
openshift-ci-robot
removed
the
backports/unvalidated-commits
jluhrsen
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jluhrsen, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@jluhrsen: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold Revision 25af2bb was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest-required |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
Many clusters block direct requests from internal resources to the nodes external IPs as best practice. All accesses from internal resources that want to access resources running on nodes go through load balancers, nodes being on private or public subnets. Let's prefer internal IPs first, so the tests can work even when there are security group rules present blocking requests to the external IPs.
We should not require ExternalIP for Conformance, but should keep testing ExternalIPs in sig network.
Signed-off-by: Rafael Fonseca r4f4rfs@gmail.com
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: