Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force using host go always and use host libriaries #1650

Closed
wants to merge 1 commit into from
Closed

Force using host go always and use host libriaries #1650

wants to merge 1 commit into from

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Aug 2, 2023

/assign @bertinatto

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 2, 2023
@openshift-ci-robot
Copy link

@soltysh: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@soltysh
Copy link
Member Author

soltysh commented Aug 2, 2023

/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Aug 2, 2023
@openshift-ci openshift-ci bot requested review from deads2k and mfojtik August 2, 2023 13:01
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
bertinatto
bertinatto reviewed Aug 2, 2023
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ba18255 and 2 for PR HEAD 46fa2c7 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e123787 and 1 for PR HEAD 46fa2c7 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 54fa6e1 and 0 for PR HEAD 46fa2c7 in total

@openshift-ci-robot
Copy link

/hold

Revision 46fa2c7 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2023
@bertinatto
Copy link
Member

/test unit

@bertinatto
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 54fa6e1 and 2 for PR HEAD 46fa2c7 in total

@bertinatto
Copy link
Member

/test unit

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5b94811 and 1 for PR HEAD 46fa2c7 in total

@bertinatto
Copy link
Member

/retest-required

@soltysh
Copy link
Member Author

soltysh commented Aug 10, 2023

This was already picked in #1660

@soltysh soltysh closed this Aug 10, 2023
@soltysh soltysh deleted the use_host_go branch August 10, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@soltysh @openshift-ci-robot @bertinatto