Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-16166: Update to Kubernetes 1.27.4 #1660

Merged
merged 4 commits into from Aug 9, 2023

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Aug 8, 2023

Brings back #1645 which was reverted in #1653 due to https://issues.redhat.com/browse/TRT-1179.

The identified problems were:

  1. statefulset, which is fixed as part of this PR (see UPSTREAM: 119761: Statefulset should wait for new replicas when removing .start.ordinal commit)
  2. the daemonset one is fixed with the fixes in 1.27.4 (specifically Automated cherry pick of #118716 upstream release 1.27 kubernetes/kubernetes#118911), which is included here, but we need to coordinate merging this change immediately with this PR to origin for those cases when external binaries don't work.

/assign @bertinatto

…ing .start.ordinal

Drop [Feature: tag to make sure this tests runs on pre-submits

In v1.27 StatefulSetStartOrdinal became beta, which makes it on by
default, but we forgot to turn these tests on along with it. This makes
these tests run always.
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 8, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 8, 2023
@openshift-ci-robot
Copy link

@soltysh: This pull request references Jira Issue OCPBUGS-16166, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (dpunia@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Brings back #1645 which was reverted in #1653 due to https://issues.redhat.com/browse/TRT-1179.

The identified problems were:

  1. statefulset, which is fixed as part of this PR (see [UPSTREAM: 119761: Statefulset should wait for new replicas when removing .start.ordinal commit)
  2. the daemonset one is fixed with the fixes in 1.27.4 (specifically Automated cherry pick of #118716 upstream release 1.27 kubernetes/kubernetes#118911), which is included here, but we need to coordinate merging this change immediately with this PR to origin for those cases when external binaries don't work.

/assign @bertinatto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@soltysh: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from mfojtik and mrunalp August 8, 2023 10:41
@openshift-ci openshift-ci bot added vendor-update Touching vendor dir or related files approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 8, 2023
@openshift-ci-robot
Copy link

@soltysh: This pull request references Jira Issue OCPBUGS-16166, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (dpunia@redhat.com), skipping review request.

In response to this:

Brings back #1645 which was reverted in #1653 due to https://issues.redhat.com/browse/TRT-1179.

The identified problems were:

  1. statefulset, which is fixed as part of this PR (see UPSTREAM: 119761: Statefulset should wait for new replicas when removing .start.ordinal commit)
  2. the daemonset one is fixed with the fixes in 1.27.4 (specifically Automated cherry pick of #118716 upstream release 1.27 kubernetes/kubernetes#118911), which is included here, but we need to coordinate merging this change immediately with this PR to origin for those cases when external binaries don't work.

/assign @bertinatto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Member Author

soltysh commented Aug 8, 2023

/test unit

@soltysh
Copy link
Member Author

soltysh commented Aug 8, 2023

/hold
for openshift/origin#28148

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2023
@soltysh
Copy link
Member Author

soltysh commented Aug 8, 2023

/test unit

Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Member Author

soltysh commented Aug 8, 2023

/remove-label backports/unvalidated-commits
/label backports/validated-commits

/override ci/prow/verify-commits
this never passes on k8s bump

@openshift-ci openshift-ci bot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Aug 8, 2023
@soltysh
Copy link
Member Author

soltysh commented Aug 8, 2023

/test e2e-aws-ovn-serial

@openshift-ci openshift-ci bot removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2023

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify-commits

In response to this:

/remove-label backports/unvalidated-commits
/label backports/validated-commits

/override ci/prow/verify-commits
this never passes on k8s bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bertinatto
Copy link
Member

/test e2e-aws-ovn-serial

@stlaz
Copy link
Member

stlaz commented Aug 9, 2023

/test e2e-aws-ovn-serial
running out of AWS capacity it seems

@soltysh
Copy link
Member Author

soltysh commented Aug 9, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 9, 2023

@soltysh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 54fa6e1 into openshift:master Aug 9, 2023
22 checks passed
@openshift-ci-robot
Copy link

@soltysh: Jira Issue OCPBUGS-16166: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-16166 has not been moved to the MODIFIED state.

In response to this:

Brings back #1645 which was reverted in #1653 due to https://issues.redhat.com/browse/TRT-1179.

The identified problems were:

  1. statefulset, which is fixed as part of this PR (see UPSTREAM: 119761: Statefulset should wait for new replicas when removing .start.ordinal commit)
  2. the daemonset one is fixed with the fixes in 1.27.4 (specifically Automated cherry pick of #118716 upstream release 1.27 kubernetes/kubernetes#118911), which is included here, but we need to coordinate merging this change immediately with this PR to origin for those cases when external binaries don't work.

/assign @bertinatto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants