Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-17417: pull newer busybox from docker until upstream can be updated. #1666

Closed
wants to merge 1 commit into from
Closed

OCPBUGS-17417: pull newer busybox from docker until upstream can be updated. #1666

wants to merge 1 commit into from

Conversation

jaypoulz
Copy link

What type of PR is this?

/kind bug
/kind failing-test
/kind regression

What this PR does / why we need it:

This PR is a temporary workaround to update the busybox image used for in our e2e tests. We determined that the current image fails to deploy when running in a privileged context with selinuxuser_execmod=off. We will try to get this accepted upstream by backporting: kubernetes#119636 (comment)

Which issue(s) this PR fixes:

Fixes OCPBUGS-17417

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 15, 2023
@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Aug 15, 2023
@openshift-ci-robot
Copy link

@jaypoulz: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@jaypoulz jaypoulz changed the title OCPBUGS-17417 pull newer busybox from docker upstream can be updated. OCPBUGS-17417 pull newer busybox from docker until upstream can be updated. Aug 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2023

@jaypoulz: The label(s) kind/regression cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind bug
/kind failing-test
/kind regression

What this PR does / why we need it:

This PR is a temporary workaround to update the busybox image used for in our e2e tests. We determined that the current image fails to deploy when running in a privileged context with selinuxuser_execmod=off. We will try to get this accepted upstream by backporting: kubernetes#119636 (comment)

Which issue(s) this PR fixes:

Fixes OCPBUGS-17417

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from mfojtik and soltysh August 15, 2023 01:09
@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaypoulz
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaypoulz
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

@jaypoulz: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jaypoulz jaypoulz changed the title OCPBUGS-17417 pull newer busybox from docker until upstream can be updated. OCPBUGS-17417: pull newer busybox from docker until upstream can be updated. Aug 15, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 15, 2023
@openshift-ci-robot
Copy link

@jaypoulz: This pull request references Jira Issue OCPBUGS-17417, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What type of PR is this?

/kind bug
/kind failing-test
/kind regression

What this PR does / why we need it:

This PR is a temporary workaround to update the busybox image used for in our e2e tests. We determined that the current image fails to deploy when running in a privileged context with selinuxuser_execmod=off. We will try to get this accepted upstream by backporting: kubernetes#119636 (comment)

Which issue(s) this PR fixes:

Fixes OCPBUGS-17417

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jaypoulz
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

@jaypoulz: This pull request references Jira Issue OCPBUGS-17417, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jaypoulz
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 15, 2023
@openshift-ci-robot
Copy link

@jaypoulz: This pull request references Jira Issue OCPBUGS-17417, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @djslavens

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 15, 2023
@openshift-ci openshift-ci bot requested a review from djslavens August 15, 2023 13:45
@jaypoulz
Copy link
Author

/retest required

@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2023

@jaypoulz: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test artifacts
  • /test configmap-scale
  • /test e2e-aws-jenkins
  • /test e2e-aws-ovn-cgroupsv2
  • /test e2e-aws-ovn-crun
  • /test e2e-aws-ovn-downgrade
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-serial
  • /test e2e-aws-ovn-upgrade
  • /test e2e-azure-ovn-upgrade
  • /test e2e-gcp
  • /test e2e-gcp-ovn-upgrade
  • /test images
  • /test integration
  • /test k8s-e2e-conformance-aws
  • /test k8s-e2e-gcp-ovn
  • /test k8s-e2e-gcp-serial
  • /test unit
  • /test verify
  • /test verify-commits

The following commands are available to trigger optional jobs:

  • /test e2e-agnostic-ovn-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-single-node
  • /test e2e-azure
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack
  • /test e2e-openstack-csi-cinder
  • /test e2e-openstack-csi-manila
  • /test e2e-vsphere
  • /test k8s-e2e-aws
  • /test k8s-e2e-aws-ovn-serial
  • /test k8s-e2e-gcp-five-control-plane-replicas

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-kubernetes-master-e2e-agnostic-ovn-cmd
  • pull-ci-openshift-kubernetes-master-e2e-aws-csi
  • pull-ci-openshift-kubernetes-master-e2e-aws-ovn-cgroupsv2
  • pull-ci-openshift-kubernetes-master-e2e-aws-ovn-crun
  • pull-ci-openshift-kubernetes-master-e2e-aws-ovn-fips
  • pull-ci-openshift-kubernetes-master-e2e-aws-ovn-serial
  • pull-ci-openshift-kubernetes-master-e2e-gcp
  • pull-ci-openshift-kubernetes-master-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-kubernetes-master-images
  • pull-ci-openshift-kubernetes-master-integration
  • pull-ci-openshift-kubernetes-master-k8s-e2e-aws-ovn-serial
  • pull-ci-openshift-kubernetes-master-k8s-e2e-conformance-aws
  • pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-ovn
  • pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-serial
  • pull-ci-openshift-kubernetes-master-unit
  • pull-ci-openshift-kubernetes-master-verify
  • pull-ci-openshift-kubernetes-master-verify-commits

In response to this:

/retest required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jaypoulz
Copy link
Author

/retest-required

1 similar comment
@jaypoulz
Copy link
Author

/retest-required

soltysh
soltysh suggested changes Aug 16, 2023
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit needs to be named:
UPSTREAM: 119636: update the busybox test image to 1.36.1
to allow us to properly include it in bumps

test/utils/image/manifest.go
@@ -242,7 +242,7 @@ func initImageConfigs(list RegistryList) (map[ImageID]Config, map[ImageID]Config
configs[AuthenticatedWindowsNanoServer] = Config{list.GcAuthenticatedRegistry, "windows-nanoserver", "v1"}
configs[APIServer] = Config{list.PromoterE2eRegistry, "sample-apiserver", "1.17.7"}
configs[AppArmorLoader] = Config{list.PromoterE2eRegistry, "apparmor-loader", "1.4"}
configs[BusyBox] = Config{list.PromoterE2eRegistry, "busybox", "1.29-4"}
configs[BusyBox] = Config{list.DockerLibraryRegistry, "busybox", "1.36.1"}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen that change in upstream, so why do we need it?

@openshift-ci
Copy link

openshift-ci bot commented Sep 11, 2023

@jaypoulz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit de9b0bf link true /test unit
ci/prow/e2e-aws-ovn-cgroupsv2 de9b0bf link true /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-gcp de9b0bf link true /test e2e-gcp
ci/prow/verify-commits de9b0bf link true /test verify-commits
ci/prow/e2e-aws-ovn-crun de9b0bf link true /test e2e-aws-ovn-crun
ci/prow/e2e-aws-ovn-serial de9b0bf link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-fips de9b0bf link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-crun-wasm de9b0bf link true /test e2e-aws-crun-wasm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jaypoulz
Copy link
Author

No longer needed. Fixed upstream.

@jaypoulz jaypoulz closed this Oct 11, 2023
@openshift-ci-robot
Copy link

@jaypoulz: This pull request references Jira Issue OCPBUGS-17417. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

What type of PR is this?

/kind bug
/kind failing-test
/kind regression

What this PR does / why we need it:

This PR is a temporary workaround to update the busybox image used for in our e2e tests. We determined that the current image fails to deploy when running in a privileged context with selinuxuser_execmod=off. We will try to get this accepted upstream by backporting: kubernetes#119636 (comment)

Which issue(s) this PR fixes:

Fixes OCPBUGS-17417

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh requested changes

@mfojtik mfojtik Awaiting requested review from mfojtik

@djslavens djslavens Awaiting requested review from djslavens

Assignees
No one assigned
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaypoulz @openshift-ci-robot @soltysh