Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-18285,OCPBUGS-19479: Update to Kubernetes 1.27.6 #1709

Merged
merged 95 commits into from Sep 22, 2023

Conversation

bertinatto
Copy link
Member

/assign @soltysh

cvvz and others added 30 commits April 12, 2023 09:42
commit 1b3ae27e7af577372d5aaaf28ea401eb33d1c4df
Author: weizhichen <weizhichen@microsoft.com>
Date:   Thu Mar 9 08:39:04 2023 +0000

    fix

commit 566e139308e3cec4c9d4765eb4ccc3a735346c2e
Author: weizhichen <weizhichen@microsoft.com>
Date:   Thu Mar 9 08:36:32 2023 +0000

    fix unit test

commit 13a58ebd25b824dcf854a132e9ac474c8296f0bf
Author: weizhichen <weizhichen@microsoft.com>
Date:   Thu Mar 2 03:32:39 2023 +0000

    add unit test

commit c984e36e37c41bbef8aec46fe3fe81ab1c6a2521
Author: weizhichen <weizhichen@microsoft.com>
Date:   Tue Feb 28 15:25:56 2023 +0000

    fix imports

commit 58ec617e0ff1fbd209ca0af3237017679c3c0ad7
Author: weizhichen <weizhichen@microsoft.com>
Date:   Tue Feb 28 15:24:21 2023 +0000

    delete CheckVolumeExistenceOperation

commit 0d8cf0caa78bdf1f1f84ce011c4cc0e0de0e8707
Author: weizhichen <weizhichen@microsoft.com>
Date:   Tue Feb 28 14:29:37 2023 +0000

    fix 111933
… creation

The topology.kubernetes.io/zone label may be added by could provider
asynchronously after the Node is created. The previous code didn't
update the topology cache after receiving the Node update event, causing
TopologyAwareHint to not work until kube-controller-manager restarts or
other Node events trigger the update.

Signed-off-by: Quan Tian <qtian@vmware.com>
The member variable `cpuRatiosByZone` should be accessed with the lock
acquired as it could be be updated by `SetNodes` concurrently.

Signed-off-by: Quan Tian <qtian@vmware.com>
Co-authored-by: Antonio Ojea <aojea@google.com>
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
This allow for a small time jump backward after
certificates generation.

Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
reconstructVolume() is called when kubelet may not have connection to the
API server yet, therefore it cannot get CSIDriver instances to figure out
if a CSI volume is attachable or not.

Refactor reconstructVolume(), so it does not need
FindAttachablePluginBySpec for CSI volumes, because all of them are
deviceMountable (i.e. FindDeviceMountablePluginBySpec always returns the
CSI volume plugin).
During CSI volume reconstruction it's not possible to tell, if the volume
is attachable or not - CSIDriver instance may not be available, because
kubelet may not have connection to the API server at that time.

Adding uncertain state during reconstruction + adding a correct state when
the API server is available.
node.status.volumesInUse should report only attachable volumes, therefore
it needs to wait for the reconciler to update uncertain attachability of
volumes from the API server.
To volumesNeedUpdateFromNodeStatus - because both devicePath and uncertain
attach-ability needs to be fixed from node status.
to be in sync with volumesNeedUpdateFromNodeStatus.
Change-Id: Ic282a57169cab8dc498574f08b081914218a1039
# Conflicts:
#	pkg/controller/job/job_controller.go
ReadWriteOncePod feature needs min requirement of 1.27 kubelet, add the
tag to skip test if kubelet version is smaller than 1.27

Change-Id: I27959156db90f2477cead6dfc16f42dbc54663bc
…ick-of-#118451-upstream-release-1.27

Add mininumKubelet tag into ReadWriteOncePod test
…ax seats

Max seats from prioriy & fairness work estimator is now min(0.15 x
nominalCL, nominalCL/handSize)

'Max seats' calculated by work estimator is currently hard coded to 10.
When using lower values for --max-requests-inflight, a single
LIST request taking up 10 seats could end up using all if not most seats in
the priority level. This change updates the default work estimator
config such that 'max seats' is at most 10% of the
maximum concurrency limit for a priority level, with an upper limit of 10.
This ensures seats taken from LIST request is proportional to the total
available seats.

Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
image_list.go is one of the files included in the non-test variant Go build list, but its getSampleDevicePluginPod function references readDaemonSetV1OrDie function defined in device_plugin_test.go which is included in the test variant Go build list only. (The file name is *_test.go).

As a result, "go build" fails with the undefined reference error.

In practice, that may not be an issue since k8s project contributors aren't meant to run go build on this package. However, tools that depend on go build to operate - e.g., gopls or govulncheck ./... - will report this as an error.

Fix this error and make test/e2e package pass go build by moving this file to also test-only source code.
…y-pick-of-#118601-origin-release-1.27

Automated cherry pick of kubernetes#118601: priority & fairness: support dynamic max seats
…f-#118549-upstream-release-1.27

Automated cherry pick of kubernetes#118549: fix 'pod' in kubelet prober metrics
…ick-of-#118922-upstream-release-1.27

Automated cherry pick of kubernetes#118922: kubeadm: backdate generated CAs
…k-of-#119434-upstream-release-1.27

Automated cherry pick of kubernetes#119434: Include ignored pods when computing backoff delay for Job pod
…of-#116134-origin-release-1.27

Automated cherry pick of kubernetes#116134: fix: After a Node is down and take some time to get back to up again, the mount point of the evicted Pods cannot be cleaned up successfully.
…-pick-of-#117449-upstream-release-1.27

Automated cherry pick of kubernetes#117449: e2e: fix flaky test 'should contain OpenAPI V3 for Aggregated
…ck-of-#117710-upstream-release-1.27

Automated cherry pick of kubernetes#117710: e2e_node: move getSampleDevicePluginPod to
…ick-of-#117804-upstream-release-1.27

Automated cherry pick of kubernetes#117804: Refactor FindAttachablePluginBySpec out of CSI code path
…of-#117245-kubernetes#117249-upstream-release-1.27

Automated cherry pick of kubernetes#117245: Fix TopologyAwareHint not working when zone label is added
kubernetes#117249: Fix a data race in TopologyCache
@sdodson sdodson added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 20, 2023
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both CI and nightly paylaod are green except for metal, which looking at release status is a wider problem.
/lgtm
/approve
/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Sep 22, 2023
@soltysh
Copy link
Member

soltysh commented Sep 22, 2023

/override ci/prow/verify-commits
this never passes on k8s bump

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify-commits

In response to this:

/override ci/prow/verify-commits
this never passes on k8s bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Member

soltysh commented Sep 22, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 22, 2023
@gangwgr
Copy link

gangwgr commented Sep 22, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 22, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2c287eb and 2 for PR HEAD 3cb8b51 in total

@soltysh
Copy link
Member

soltysh commented Sep 22, 2023

/test e2e-azure-ovn-upgrade

1 similar comment
@soltysh
Copy link
Member

soltysh commented Sep 22, 2023

/test e2e-azure-ovn-upgrade

@soltysh
Copy link
Member

soltysh commented Sep 22, 2023

The 504 Gateway issue is a known problem tracked in https://issues.redhat.com/browse/OCPBUGS-18999 and we also got a green azure-ovn-upgrade in https://pr-payload-tests.ci.openshift.org/runs/ci/2fa51ea0-5798-11ee-8dd2-90e5dbb2a705-1 so I'm confident this is not broken.
/override ci/prow/e2e-azure-ovn-upgrade

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-azure-ovn-upgrade

In response to this:

The 504 Gateway issue is a known problem tracked in https://issues.redhat.com/browse/OCPBUGS-18999 and we also got a green azure-ovn-upgrade in https://pr-payload-tests.ci.openshift.org/runs/ci/2fa51ea0-5798-11ee-8dd2-90e5dbb2a705-1 so I'm confident this is not broken.
/override ci/prow/e2e-azure-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

@bertinatto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade 3cb8b51 link true /test e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1648878 into openshift:release-4.14 Sep 22, 2023
23 checks passed
@openshift-ci-robot
Copy link

@bertinatto: Jira Issue OCPBUGS-18285: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-18285 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-19479: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19479 has been moved to the MODIFIED state.

In response to this:

/assign @soltysh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.14.0-0.nightly-2023-09-22-154021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. backports/validated-commits Indicates that all commits come to merged upstream PRs. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet