Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 120817: e2e: bootstrap vsphere tests earlier #1714

Merged
merged 2 commits into from
Sep 26, 2023
Merged

UPSTREAM: 120817: e2e: bootstrap vsphere tests earlier #1714

merged 2 commits into from
Sep 26, 2023

Conversation

bertinatto
Copy link
Member

@bertinatto bertinatto commented Sep 19, 2023 •
edited
Loading

/assign @soltysh

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Sep 19, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2023
@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@bertinatto
Copy link
Member Author

/skip

@bertinatto
Copy link
Member Author

/test e2e-vsphere

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@bertinatto
Copy link
Member Author

/skip

@bertinatto
Copy link
Member Author

/test e2e-vsphere

1 similar comment
@bertinatto
Copy link
Member Author

/test e2e-vsphere

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@bertinatto
Copy link
Member Author

/test e2e-vsphere

@bertinatto bertinatto marked this pull request as draft September 21, 2023 11:15
@bertinatto
Copy link
Member Author

/test e2e-vsphere

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@bertinatto
Copy link
Member Author

/test e2e-vsphere

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@bertinatto
Copy link
Member Author

/test e2e-vsphere

1 similar comment
@bertinatto
Copy link
Member Author

/test e2e-vsphere

@bertinatto
Copy link
Member Author

/test e2e-vsphere-csi

@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2023

@bertinatto: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test artifacts
  • /test configmap-scale
  • /test e2e-aws-crun-wasm
  • /test e2e-aws-jenkins
  • /test e2e-aws-ovn-cgroupsv2
  • /test e2e-aws-ovn-crun
  • /test e2e-aws-ovn-downgrade
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-serial
  • /test e2e-aws-ovn-upgrade
  • /test e2e-azure-ovn-upgrade
  • /test e2e-gcp
  • /test e2e-gcp-ovn-upgrade
  • /test images
  • /test integration
  • /test k8s-e2e-conformance-aws
  • /test k8s-e2e-gcp-ovn
  • /test k8s-e2e-gcp-serial
  • /test unit
  • /test verify
  • /test verify-commits

The following commands are available to trigger optional jobs:

  • /test e2e-agnostic-ovn-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-single-node
  • /test e2e-azure
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack
  • /test e2e-openstack-csi-cinder
  • /test e2e-openstack-csi-manila
  • /test e2e-vsphere
  • /test k8s-e2e-aws
  • /test k8s-e2e-aws-ovn-serial
  • /test k8s-e2e-gcp-five-control-plane-replicas

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-kubernetes-master-e2e-agnostic-ovn-cmd
  • pull-ci-openshift-kubernetes-master-e2e-aws-crun-wasm
  • pull-ci-openshift-kubernetes-master-e2e-aws-csi
  • pull-ci-openshift-kubernetes-master-e2e-aws-ovn-cgroupsv2
  • pull-ci-openshift-kubernetes-master-e2e-aws-ovn-crun
  • pull-ci-openshift-kubernetes-master-e2e-aws-ovn-fips
  • pull-ci-openshift-kubernetes-master-e2e-aws-ovn-serial
  • pull-ci-openshift-kubernetes-master-e2e-gcp
  • pull-ci-openshift-kubernetes-master-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-kubernetes-master-images
  • pull-ci-openshift-kubernetes-master-integration
  • pull-ci-openshift-kubernetes-master-k8s-e2e-aws-ovn-serial
  • pull-ci-openshift-kubernetes-master-k8s-e2e-conformance-aws
  • pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-ovn
  • pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-serial
  • pull-ci-openshift-kubernetes-master-unit
  • pull-ci-openshift-kubernetes-master-verify
  • pull-ci-openshift-kubernetes-master-verify-commits

In response to this:

/test e2e-vsphere-csi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@bertinatto bertinatto changed the title WIP: Bootstrap vsphere earlier UPSTREAM: 120817: e2e: bootstrap vsphere tests earlier Sep 25, 2023
@bertinatto bertinatto marked this pull request as ready for review September 25, 2023 14:42
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2023
@bertinatto
Copy link
Member Author

/hold cancel
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_kubernetes/1714/pull-ci-openshift-kubernetes-master-e2e-vsphere/1706318531160707072

@openshift-ci openshift-ci bot added vendor-update Touching vendor dir or related files and removed lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 25, 2023
@soltysh
Copy link

soltysh commented Sep 25, 2023

/lgtm
/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. lgtm Indicates that a PR is ready to be merged. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Sep 25, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bertinatto
Copy link
Member Author

/retest-required

1 similar comment
@bertinatto
Copy link
Member Author

/retest-required

@bertinatto
Copy link
Member Author

/test unit

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7545fd9 and 2 for PR HEAD fababfc in total

@bertinatto
Copy link
Member Author

/retest-required

1 similar comment
@bertinatto
Copy link
Member Author

/retest-required

@mkowalski
Copy link

/test unit

 === Failed
=== FAIL: pkg/controller/volume/expand  (0.00s)
signal: segmentation fault (core dumped)
FAIL	k8s.io/kubernetes/pkg/controller/volume/expand	1.085s
=== FAIL: pkg/kubelet/cadvisor  (0.00s)
signal: segmentation fault (core dumped)
FAIL	k8s.io/kubernetes/pkg/kubelet/cadvisor	1.384s

@mkowalski
Copy link

/test e2e-aws-ovn-fips

level=error msg=Bootstrap failed to complete: timed out waiting for the condition

@soltysh
Copy link

soltysh commented Sep 26, 2023

/override ci/prow/e2e-aws-ovn-fips
we're working on fixing the fips bits in a different PR, and this is to unblock vsphere

@mkowalski mkowalski mentioned this pull request Sep 26, 2023
Merged
@openshift-ci
Copy link

openshift-ci bot commented Sep 26, 2023

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-aws-ovn-fips

In response to this:

/override ci/prow/e2e-aws-ovn-fips
we're working on fixing the fips bits in a different PR, and this is to unblock vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 26, 2023

@bertinatto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e3ba6d9 into openshift:master Sep 26, 2023
19 checks passed
@mkowalski
Copy link

Hey @bertinatto, are you cherry-picking to release-4.14 like any other repo or do you have some other process in o/kubernetes?

@martinkennelly
Copy link

I am also looking for 4.14 backport - i am seeing it on our vsphere 4.14 CI.

@martinkennelly martinkennelly mentioned this pull request Sep 28, 2023
Merged
@bertinatto
Copy link
Member Author

@mkowalski @martinkennelly can you point me to a 4.14 job? The regression that this fix addresses was introduced in k8s 1.28 (OCP 4.15) and AFAIK is not present in k8s 1.27 (OCP 4.14).

@bertinatto
Copy link
Member Author

@mkowalski @martinkennelly can you point me to a 4.14 job? The regression that this fix addresses was introduced in k8s 1.28 (OCP 4.15) and AFAIK is not present in k8s 1.27 (OCP 4.14).

Oh, the regression was "backported" to k8s 1.27: kubernetes#120436

@bertinatto
Copy link
Member Author

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@bertinatto: #1714 failed to apply on top of branch "release-4.14":

Applying: UPSTREAM: 120817: e2e: bootstrap vsphere tests earlier
Applying: UPSTREAM: <drop>: hack/update-vendor.sh (with updated builder image)
Using index info to reconstruct a base tree...
M	go.sum
M	staging/src/k8s.io/api/go.sum
M	staging/src/k8s.io/apiextensions-apiserver/go.sum
M	staging/src/k8s.io/apimachinery/go.sum
M	staging/src/k8s.io/apiserver/go.sum
M	staging/src/k8s.io/cli-runtime/go.sum
M	staging/src/k8s.io/client-go/go.sum
M	staging/src/k8s.io/cloud-provider/go.sum
M	staging/src/k8s.io/cluster-bootstrap/go.sum
M	staging/src/k8s.io/code-generator/go.sum
M	staging/src/k8s.io/component-base/go.sum
M	staging/src/k8s.io/component-helpers/go.sum
M	staging/src/k8s.io/controller-manager/go.sum
M	staging/src/k8s.io/cri-api/go.sum
M	staging/src/k8s.io/csi-translation-lib/go.sum
M	staging/src/k8s.io/dynamic-resource-allocation/go.sum
A	staging/src/k8s.io/endpointslice/go.sum
M	staging/src/k8s.io/kms/go.sum
M	staging/src/k8s.io/kube-aggregator/go.sum
M	staging/src/k8s.io/kube-controller-manager/go.sum
M	staging/src/k8s.io/kube-proxy/go.sum
M	staging/src/k8s.io/kube-scheduler/go.sum
M	staging/src/k8s.io/kubectl/go.sum
M	staging/src/k8s.io/kubelet/go.sum
M	staging/src/k8s.io/legacy-cloud-providers/go.sum
M	staging/src/k8s.io/metrics/go.sum
M	staging/src/k8s.io/pod-security-admission/go.sum
M	staging/src/k8s.io/sample-apiserver/go.sum
M	staging/src/k8s.io/sample-cli-plugin/go.sum
M	staging/src/k8s.io/sample-controller/go.sum
Falling back to patching base and 3-way merge...
Auto-merging staging/src/k8s.io/sample-controller/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/sample-controller/go.sum
Auto-merging staging/src/k8s.io/sample-cli-plugin/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/sample-cli-plugin/go.sum
Auto-merging staging/src/k8s.io/sample-apiserver/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/sample-apiserver/go.sum
Auto-merging staging/src/k8s.io/pod-security-admission/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/pod-security-admission/go.sum
Auto-merging staging/src/k8s.io/metrics/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/metrics/go.sum
Auto-merging staging/src/k8s.io/legacy-cloud-providers/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/legacy-cloud-providers/go.sum
Auto-merging staging/src/k8s.io/kubelet/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/kubelet/go.sum
Auto-merging staging/src/k8s.io/kubectl/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/kubectl/go.sum
Auto-merging staging/src/k8s.io/kube-scheduler/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/kube-scheduler/go.sum
Auto-merging staging/src/k8s.io/kube-proxy/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/kube-proxy/go.sum
Auto-merging staging/src/k8s.io/kube-controller-manager/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/kube-controller-manager/go.sum
Auto-merging staging/src/k8s.io/kube-aggregator/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/kube-aggregator/go.sum
Auto-merging staging/src/k8s.io/kms/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/kms/go.sum
CONFLICT (modify/delete): staging/src/k8s.io/endpointslice/go.sum deleted in HEAD and modified in UPSTREAM: <drop>: hack/update-vendor.sh (with updated builder image). Version UPSTREAM: <drop>: hack/update-vendor.sh (with updated builder image) of staging/src/k8s.io/endpointslice/go.sum left in tree.
Auto-merging staging/src/k8s.io/dynamic-resource-allocation/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/dynamic-resource-allocation/go.sum
Auto-merging staging/src/k8s.io/csi-translation-lib/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/csi-translation-lib/go.sum
Auto-merging staging/src/k8s.io/cri-api/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/cri-api/go.sum
Auto-merging staging/src/k8s.io/controller-manager/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/controller-manager/go.sum
Auto-merging staging/src/k8s.io/component-helpers/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/component-helpers/go.sum
Auto-merging staging/src/k8s.io/component-base/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/component-base/go.sum
Auto-merging staging/src/k8s.io/code-generator/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/code-generator/go.sum
Auto-merging staging/src/k8s.io/cluster-bootstrap/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/cluster-bootstrap/go.sum
Auto-merging staging/src/k8s.io/cloud-provider/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/cloud-provider/go.sum
Auto-merging staging/src/k8s.io/client-go/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/client-go/go.sum
Auto-merging staging/src/k8s.io/cli-runtime/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/cli-runtime/go.sum
Auto-merging staging/src/k8s.io/apiserver/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/apiserver/go.sum
Auto-merging staging/src/k8s.io/apimachinery/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/apimachinery/go.sum
Auto-merging staging/src/k8s.io/apiextensions-apiserver/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/apiextensions-apiserver/go.sum
Auto-merging staging/src/k8s.io/api/go.sum
CONFLICT (content): Merge conflict in staging/src/k8s.io/api/go.sum
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 UPSTREAM: <drop>: hack/update-vendor.sh (with updated builder image)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkowalski mkowalski mentioned this pull request Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bertinatto @openshift-ci-robot @soltysh @mkowalski @martinkennelly @openshift-cherrypick-robot @openshift-merge-robot