Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPNODE-1892: Bump k8s to 1.29.2 #1888

Merged
merged 26 commits into from Feb 21, 2024

Conversation

sairameshv
Copy link
Member

Bump k8s api to 1.29.2

/assign @soltysh

danwinship and others added 26 commits January 13, 2024 12:30
ServicePortMap.Update() and EndpointsMap.Update() were just a tiny
wrappers around the corresponding apply() methods, which had no other
callers. So squash them together.

(Also fix the variable naming in ServicePortMap.Update() to match
other methods.)
…ults

This fixes a race condition where the tracker could be updated in
between us calling .PendingChanges() and .Update().
Don't create admin rolebindings when --kubeconfig is set to a
non-default value.

Fixes: kubernetes/kubeadm#2992

Signed-off-by: Mario Valderrama <mario.valderrama@ionos.com>
Change-Id: Ia0ad9381057a4a1a4a4490861a0d7c1a7ba800cb
snuck in there while I was working on the test, but is ultimately not necessary to test the functionality.

skipping healthz check resulted in leaking goroutines from poststarthooks.
Currently --rootfs does not work with "upgrade node" for CP nodes
because the only check of CP nodes is performed in newNodeOptions()
which runs before the root kubeadm command is run, thus the chroot()
path coming from --rootfs is not applied yet.

To work around that call the "isControlPlaneNode" check when
constructing the command data on command runtime.
…n kube-system/kubelet-config ConfigMap does not respect user patch"
…ck-of-#123093-upstream-release-1.29

Automated cherry pick of kubernetes#123093: Revert "kubeadm: fix a bug where the uploaded kubelet
…ck-of-#122735-upstream-release-1.29

Automated cherry pick of kubernetes#122735: Fix kubeadm init regression
…ck-of-#122704-upstream-release-1.29

Automated cherry pick of kubernetes#122704: If a pvc has an empty storageclass name, don't try to assign
…erry-pick-of-#123038-upstream-release-1.29

Automated cherry pick of kubernetes#123038: Fix deprecated version for pod_scheduling_duration_seconds
…rry-pick-of-#123003-upstream-release-1.29

Cherry pick of kubernetes#123003 and kubernetes#123082: bugfix: dont skip reconcile for unchanged policy if last sync
…k-of-#122204-upstream-release-1.29

Automated cherry pick of kubernetes#122204: Fix race condition in iptables partial sync handling
…y-pick-of-#122728-upstream-release-1.29

Automated cherry pick of kubernetes#122728: flag PersistentVolumeLastPhaseTransitionTime field as beta
…y-pick-of-#122750-upstream-release-1.29

Automated cherry pick of kubernetes#122750: Add processStartTime in metrics/slis
…pick-of-#123077-origin-release-1.29

Automated cherry pick of kubernetes#123077: kubeadm: better checks if the node is CP during "upgrade
…ian-base to bookworm-v1.0.1 and distroless-iptables to v0.4.5

Signed-off-by: cpanato <ctadeu@gmail.com>
[release-1.29] [go] Bump images, dependencies and versions to go 1.21.7 / setcap/debian-base to bookworm-v1.0.1 and distroless-iptables to v0.4.5
Kubernetes official release v1.29.2
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Feb 19, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2024

@sairameshv: This pull request references OCPNODE-1892 which is a valid jira issue.

In response to this:

Bump k8s api to 1.29.2

/assign @soltysh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@sairameshv: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Feb 19, 2024
@sairameshv
Copy link
Member Author

/retest

Copy link

openshift-ci bot commented Feb 20, 2024

@sairameshv: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd 8ade471 link false /test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
Copy link

openshift-ci bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sairameshv, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
@soltysh
Copy link
Member

soltysh commented Feb 20, 2024

/remove-label backports/unvalidated-commits
/remove-label backports/validated-commits

@openshift-ci openshift-ci bot removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Feb 20, 2024
Copy link

openshift-ci bot commented Feb 20, 2024

@soltysh: Those labels are not set on the issue: backports/validated-commits

In response to this:

/remove-label backports/unvalidated-commits
/remove-label backports/validated-commits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Member

soltysh commented Feb 21, 2024

/label backports/validated-commits

@openshift-ci openshift-ci bot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Feb 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ac404b9 into openshift:master Feb 21, 2024
22 of 23 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-pod-container-v4.16.0-202402211939.p0.gac404b9.assembly.stream.el9 for distgit openshift-enterprise-pod.
All builds following this will include this PR.

@sairameshv sairameshv deleted the bump-1.29.2 branch February 22, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet