No PetSet client in client/unversioned #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add fakes
|
@ironcladlou does this already existing in openshift/origin? If not, open the pull there first. Once we get a clean merge in openshift/origin, we can do a bulk pick down into openshift/kubernetes. We never want to have a state where openshift/kubernetes can't be used to build openshift/origin and right now the only way to do that is "origin first". |
|
This came in origin as part of openshift/origin#9972 |
|
Actually, does it even need to be picked into this fork? As long as the commit exists upstream and |
|
Nevermind, this isn't necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed pick of kubernetes#29655. Next, origin will need to specify b81a8de in
Godeps.jsonwhich should have been included with openshift/origin@eb0dc79.