UPSTREAM: 93508: add permissions required by endpoints controller for blockOwnerDeletion #300
Conversation
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
added
the
approved
… blockOwnerDeletion
deads2k
force-pushed
the
os-endpointmirror
branch
from
e9bdf5f
to
9da895d
Compare
openshift-ci-robot
removed
the
needs-rebase
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, marun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
gcp-e2e-kubernetes is completely red: https://prow.ci.openshift.org/job-history/gs/origin-ci-test/pr-logs/directory/pull-ci-openshift-kubernetes-master-gcp-e2e-kubernetes I see it's required for this PR, but will it actually pass? |
|
/retest |
It's supposed to be optional. When I renamed the job I missed the detail that I would need to manually set optional to true in the generated job. This seems like a footgun, and I'm left wondering why it's not possible to set all job fields from template config. |
|
@marun after make update youll have to go in manually and add optional: true manually: |
|
/retest |
|
/override ci/prow/gcp-e2e-kubernetes This is supposed to be optional until we have walked through getting it everything to run on OpenShift. |
|
@sttts: Overrode contexts on behalf of sttts: ci/prow/gcp-e2e-kubernetes In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@deads2k: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/gcp-e2e-kubernetes These were made required accidently. |
|
/override ci/prow/kubernetes-e2e |
|
@sttts: Overrode contexts on behalf of sttts: ci/prow/gcp-e2e-kubernetes In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sttts: Overrode contexts on behalf of sttts: ci/prow/kubernetes-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Button merge to stop bleeding. Tests are green. Just skipping retest. |
kubernetes#93508
fixes problems in upgrade test https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/25314/pull-ci-openshift-origin-master-e2e-gcp-upgrade/1287993294235635712